Repository navigation
CPP: Prevent forced bad join order which is saved by context. - #18828
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
FYI: I've kicked-off a DCA experiment. |
jketema
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is impossible to avoid a CP in this predicate on it's own.
Picking
getClassAndNamefirst is always a CP as it doesn't usenameWithoutArgs. This disjunct cannot be picked asnot method instanceof ConversionOperatorrequiresmethodto be bound first.In practice the argument
resultalso happens to be bound at the call site, sogetClassAndNameis not a CP at the call site. However the call site has no idea that we needmethodto be bound and we join order assuming that it isn't so it. We also assume it isn't bound internally. This means that the join order is quite sensitive.An alternative would be to add
resultto the binding set to get a similar effect to what we do now (I wasn't sure whether to make this do what seems to be intended or whether to preserve the existing join order).