Fix interaction between defaultAdditionalTaintStep and defaultImplicitTaintRead #18776
+149
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultImplicitTaintRead
is described as follows:However where we implement the functionality of
defaultImplicitTaintRead
(inallowImplicitRead
, see the first commit), it is only applied at sinks and additional taint steps defined in the configuration. Additional taint steps defined viadefaultAdditionalTaintStep
are overlooked.In Rust, one such
defaultAdditionalTaintStep
is for concatenation with+
, and one suchdefaultImplicitTaintRead
is for reading from reference content. As a result we've been missing flow in common cases like this:This PR is a draft (for now) because I'm nervous of unintended consequences, or whether this interaction was left out on purpose (for performance reasons perhaps). The change is in shared code and may affect all languages.
TODO: