Codegen: Improve return type of self-typed properties #18635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For classes with properties that return something of the type itself, such as
the code-generator would previously refer to the internal
C
class instead of the publicC
class. In most cases this won't matter, except when the publicC
class has extra predicates added through theCImpl.qll
layer, which means that those predicates are not immediately available (see e.g. 0d5e408#diff-b227718658489f53f4601c823cba31f08b9b76ced280b3197f8bfebd4289b3e0R30).