Skip to content

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jan 30, 2025

For classes with properties that return something of the type itself, such as

class C {
  C getAnother() { ... }
}

the code-generator would previously refer to the internal C class instead of the public C class. In most cases this won't matter, except when the public C class has extra predicates added through the CImpl.qll layer, which means that those predicates are not immediately available (see e.g. 0d5e408#diff-b227718658489f53f4601c823cba31f08b9b76ced280b3197f8bfebd4289b3e0R30).

@github-actions github-actions bot added Rust Pull requests that update Rust code Swift labels Jan 30, 2025
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Jan 31, 2025
@hvitved hvitved marked this pull request as ready for review January 31, 2025 08:29
@Copilot Copilot AI review requested due to automatic review settings January 31, 2025 08:29
@hvitved hvitved requested a review from a team as a code owner January 31, 2025 08:29
@hvitved hvitved requested a review from redsun82 January 31, 2025 08:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@hvitved hvitved force-pushed the codegen/self-type-alias branch from da3922e to 3d3b785 Compare February 3, 2025 08:12
Copy link
Contributor

@redsun82 redsun82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@redsun82 redsun82 merged commit d65a704 into github:main Feb 5, 2025
25 checks passed
@hvitved hvitved deleted the codegen/self-type-alias branch February 6, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Rust Pull requests that update Rust code Swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants