Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift: add skeleton iOS app for integration testing #18509

Merged
merged 10 commits into from
Jan 22, 2025
Merged

Swift: add skeleton iOS app for integration testing #18509

merged 10 commits into from
Jan 22, 2025

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Jan 16, 2025 •
edited
Loading

The added iOS test is Xcode 16 only, as that is the only kind of project I can generate on my macOS 15 machine (Xcode 15.4 is not supported there).

On the other hand, the hello-xcode project is extended to be tested on both Xcode 15 and Xcode 16.

@redsun82 redsun82 added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Jan 16, 2025
@github-actions github-actions bot added the Swift label Jan 16, 2025
@redsun82 redsun82 marked this pull request as ready for review January 17, 2025 14:42
@Copilot Copilot bot review requested due to automatic review settings January 17, 2025 14:42
@redsun82 redsun82 requested a review from a team as a code owner January 17, 2025 14:42
Copilot
Copilot AI reviewed Jan 17, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (10)
  • swift/ql/integration-tests/osx/hello-ios/Files.expected: Language not supported
  • swift/ql/integration-tests/osx/hello-ios/Files.ql: Language not supported
  • swift/ql/integration-tests/osx/hello-ios/hello-ios.xcodeproj/project.pbxproj: Language not supported
  • swift/ql/integration-tests/osx/hello-ios/hello-ios.xcodeproj/project.xcworkspace/contents.xcworkspacedata: Language not supported
  • swift/ql/integration-tests/osx/hello-ios/hello-ios/Assets.xcassets/AccentColor.colorset/Contents.json: Language not supported
  • swift/ql/integration-tests/osx/hello-ios/hello-ios/Assets.xcassets/AppIcon.appiconset/Contents.json: Language not supported
  • swift/ql/integration-tests/osx/hello-ios/hello-ios/Assets.xcassets/Contents.json: Language not supported
  • swift/ql/integration-tests/osx/hello-ios/hello-ios/ContentView.swift: Language not supported
  • swift/ql/integration-tests/osx/hello-ios/hello-ios/Preview Content/Preview Assets.xcassets/Contents.json: Language not supported
  • swift/ql/integration-tests/osx/hello-ios/hello-ios/hello_iosApp.swift: Language not supported

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
@redsun82 redsun82 closed this Jan 20, 2025
@redsun82 redsun82 reopened this Jan 20, 2025
@redsun82 redsun82 removed the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Jan 22, 2025
@jketema
Copy link
Contributor

jketema commented Jan 22, 2025

This will call appintentsnltrainingprocessor somewhere under the hood at the moment?

@redsun82
Copy link
Contributor Author

This will call appintentsnltrainingprocessor somewhere under the hood at the moment?

Yes, that is called by xcode for pretty much any iOS app as far as I can tell. It does for the default iOS app that xcode creates with the wizard (which is how I created the xcode project). I just double-checked this by downloading the logs from this run, where test-logs-macos/ql/swift/ql/integration-tests/osx/hello-ios/test/test/test-db/log/build-tracer.log contains

relocator: explicitly skipping /Applications/Xcode_16.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/appintentsnltrainingprocessor

jketema
jketema approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redsun82 redsun82 merged commit 429365f into main Jan 22, 2025
18 checks passed
@redsun82 redsun82 deleted the redsun82/swift-ios branch January 22, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jketema jketema jketema approved these changes

Assignees
No one assigned
Labels
Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redsun82 @jketema