C++: Support if consteval and if ! consteval
#18502
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
added
the
depends on internal PR
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jketema
force-pushed
the
consteval
branch
2 times, most recently
from
c4673e1 to
f70bf5b
Compare
jketema
commented
Jan 16, 2025
Comment on lines
+881
to
+885
| p1.nodeAt(n1, s) and | ||
| p2.nodeBefore(n2, s.getThen()) | ||
| or | ||
| p1.nodeAt(n1, s) and | ||
| p2.nodeBefore(n2, s.getElse()) |
There was a problem hiding this comment.
Here we allow both branches of the consteval if to be reached.
jketema
commented
Jan 16, 2025
Comment on lines
+1145
to
+1147
| TranslatedStmt getEvaluatedBranch() { | ||
| result = getTranslatedStmt(stmt.getRuntimeEvaluatedBranch()) | ||
| } |
There was a problem hiding this comment.
We pick a single branch that can be reached. For now this is the branch that is taken at runtime, we can change this later if we see that using the compile time branch improves analysis quality.
jketema
commented
Jan 16, 2025
| from Stmt stmt, int kind, int kind_new, Location location | ||
| where | ||
| stmts(stmt, kind, location) and | ||
| if isConstevalIf(stmt) then kind_new = 7 else kind_new = kind // Turns consteval if into a block with two block statement in it |
There was a problem hiding this comment.
Suggested change
| if isConstevalIf(stmt) then kind_new = 7 else kind_new = kind // Turns consteval if into a block with two block statement in it | |
| if isConstevalIf(stmt) then kind_new = 7 else kind_new = kind // Turns consteval if into a block with two block statements in it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
All query authors
.qhelp. See the documentation in this repository.Internal query authors only
.ql,.qll, or.qhelpfiles. See the documentation (internal access required).