C++: #16009 (second attempt) #17938
Draft
C++: #16009 (second attempt) #17938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| class ConstantValueNumber extends ValueNumber { | ||
| ConstantInstruction instr; |
Check notice
Code scanning / CodeQL
Field only used in CharPred Note
MathiasVP
force-pushed
the
fix-fp-in-missing-check-scanf-fixing-take-2
branch
from
0ab5bc6
to
e0f0b0a
Compare
MathiasVP
force-pushed
the
fix-fp-in-missing-check-scanf-fixing-take-2
branch
from
e0f0b0a
to
930efc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at fixing the performance issue that was blocking #16009. Instead of materializing the guard-related predicates with
Operandcolumns we keep using value numbers to reduce the size of the predicates.This is currently a breaking change. If this turns out to fix the performance problems I'll think of a solution (and clean up the PR) 🤞