Merge pull request #18561 from jketema/jketema/scanf

C++: Fix join-order problem found on `IncorrectCheckScanf.ql`
github · Jan 23, 2025 · 8b2cfa9 · 8b2cfa9
2 parents dcdc12f + 68ec4b6
commit 8b2cfa9
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/cpp/ql/lib/semmle/code/cpp/controlflow/IRGuards.qll b/cpp/ql/lib/semmle/code/cpp/controlflow/IRGuards.qll
@@ -981,7 +981,8 @@ private module Cached {
     or
     exists(CompareValueNumber cmp, Operand left, Operand right, AbstractValue v |
       test = cmp and
-      cmp.hasOperands(left, right) and
+      pragma[only_bind_into](cmp)
+          .hasOperands(pragma[only_bind_into](left), pragma[only_bind_into](right)) and
       isConvertedBool(left.getDef()) and
       int_value(right.getDef()) = 0 and
       unary_compares_eq(valueNumberOfOperand(left), op, k, areEqual, v)