[WIP] Adding more detail to PullRequestCheckView

src/GitHub.App/SampleData/PullRequestCheckViewModelDesigner.cs

@@ -9,10 +9,14 @@ namespace GitHub.SampleData
 {
     public sealed class PullRequestCheckViewModelDesigner : ViewModelBase, IPullRequestCheckViewModel
     {
+        public bool IsRequired { get; } = true;
+
         public string Title { get; set; } = "continuous-integration/appveyor/pr";
 
         public string Description { get; set; } = "AppVeyor build failed";
 
+        public string DurationStatus { get; set; }
+
         public PullRequestCheckStatus Status { get; set; } = PullRequestCheckStatus.Failure;
 
         public Uri DetailsUrl { get; set; } = new Uri("http://github.com");

src/GitHub.App/Services/RepositoryService.cs

@@ -1,9 +1,11 @@
 using System;
 using System.Collections.Generic;
 using System.ComponentModel.Composition;
+using System.Linq;
 using System.Threading.Tasks;
 using GitHub.Api;
 using GitHub.Extensions;
+using GitHub.Models;
 using GitHub.Primitives;
 using Octokit.GraphQL;
 using static Octokit.GraphQL.Variable;
@@ -12,9 +14,10 @@ namespace GitHub.Services
 {
     [Export(typeof(IRepositoryService))]
     [PartCreationPolicy(CreationPolicy.Shared)]
-    public class RepositoryService : IRepositoryService
+    public class RepositoryService: IRepositoryService
     {
         static ICompiledQuery<Tuple<string, string>> readParentOwnerLogin;
+        static ICompiledQuery<List<ProtectedBranch>> queryProtectedBranches;
         readonly IGraphQLClientFactory graphqlFactory;
 
         [ImportingConstructor]
@@ -25,6 +28,7 @@ public RepositoryService(IGraphQLClientFactory graphqlFactory)
             this.graphqlFactory = graphqlFactory;
         }
 
+        /// <inheritdoc/>
         public async Task<(string owner, string name)?> FindParent(HostAddress address, string owner, string name)
         {
             Guard.ArgumentNotNull(address, nameof(address));
@@ -45,9 +49,49 @@ public RepositoryService(IGraphQLClientFactory graphqlFactory)
                 { nameof(name), name },
             };
 
-            var graphql = await graphqlFactory.CreateConnection(address);
-            var result = await graphql.Run(readParentOwnerLogin, vars);
+            var graphql = await graphqlFactory.CreateConnection(address).ConfigureAwait(false);
+            var result = await graphql.Run(readParentOwnerLogin, vars).ConfigureAwait(false);
             return result != null ? (result.Item1, result.Item2) : ((string, string)?)null;
         }
+
+        /// <inheritdoc/>
+        public async Task<IList<ProtectedBranch>> GetProtectedBranches(HostAddress address, string owner, string name)
+        {
+            Guard.ArgumentNotNull(address, nameof(address));
+            Guard.ArgumentNotEmptyString(owner, nameof(owner));
+            Guard.ArgumentNotEmptyString(name, nameof(name));
+
+            if (queryProtectedBranches == null)
+            {
+                queryProtectedBranches = new Query()
+                    .Repository(Var(nameof(name)), Var(nameof(owner)))
+                    .Select(r =>
+                        r.ProtectedBranches(null, null, null, null)
+                            .AllPages()
+                            .Select(branch => new ProtectedBranch
+                            {
+                                Name = branch.Name,
+                                RequiredStatusCheckContexts = branch.RequiredStatusCheckContexts.ToArray()
+                            }).ToList()
+                        ).Compile();
+            }
+
+            var vars = new Dictionary<string, object>
+            {
+                { nameof(owner), owner },
+                { nameof(name), name },
+            };
+
+            var graphql = await graphqlFactory.CreateConnection(address).ConfigureAwait(false);
+            return await graphql.Run(queryProtectedBranches, vars).ConfigureAwait(false);
+        }
+
+        /// <inheritdoc/>
+        public async Task<ProtectedBranch> GetProtectedBranch(HostAddress address, string owner, string name, string branchName)
+        {
+            Guard.ArgumentNotNull(branchName, nameof(branchName));
+            var protectedBranches = await GetProtectedBranches(address, owner, name).ConfigureAwait(false);
+            return protectedBranches.FirstOrDefault(branch => branch.Name.Equals(branchName, StringComparison.InvariantCultureIgnoreCase));
+        }
     }
 }

src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.ComponentModel.Composition;
+using System.Globalization;
 using System.Linq;
 using System.Linq.Expressions;
 using System.Reactive;
@@ -9,6 +10,7 @@
 using GitHub.Models;
 using GitHub.Primitives;
 using GitHub.Services;
+using GitHub.UI.Converters;
 using ReactiveUI;
 
 namespace GitHub.ViewModels.GitHubPane
@@ -49,6 +51,7 @@ public static IEnumerable<IPullRequestCheckViewModel> Build(IViewViewModelFactor
 
                 var pullRequestCheckViewModel = (PullRequestCheckViewModel) viewViewModelFactory.CreateViewModel<IPullRequestCheckViewModel>();
                 pullRequestCheckViewModel.CheckType = PullRequestCheckType.StatusApi;
+                pullRequestCheckViewModel.IsRequired = statusModel.IsRequired;
                 pullRequestCheckViewModel.Title = statusModel.Context;
                 pullRequestCheckViewModel.Description = statusModel.Description;
                 pullRequestCheckViewModel.Status = checkStatus;
@@ -98,10 +101,18 @@ public static IEnumerable<IPullRequestCheckViewModel> Build(IViewViewModelFactor
 
                     var pullRequestCheckViewModel = (PullRequestCheckViewModel)viewViewModelFactory.CreateViewModel<IPullRequestCheckViewModel>();
                     pullRequestCheckViewModel.CheckType = PullRequestCheckType.ChecksApi;
+                    pullRequestCheckViewModel.IsRequired = arg.checkRun.IsRequired;
                     pullRequestCheckViewModel.CheckRunId = arg.checkRun.Id;
                     pullRequestCheckViewModel.HasAnnotations = arg.checkRun.Annotations?.Any() ?? false;
                     pullRequestCheckViewModel.Title = arg.checkRun.Name;
-                    pullRequestCheckViewModel.Description = arg.checkRun.Summary;
+
+                    if (arg.checkRun.StartedAt.HasValue && arg.checkRun.CompletedAt.HasValue)
+                    {
+                        var timeSpanString = TimeSpanExtensions.Humanize(arg.checkRun.CompletedAt.Value - arg.checkRun.StartedAt.Value, CultureInfo.CurrentCulture, TimeSpanExtensions.OutputTense.Completed);
+                        pullRequestCheckViewModel.DurationStatus = $"{checkStatus} - {timeSpanString}";
+                    }
+
+                    pullRequestCheckViewModel.Description = arg.checkRun.Title;
                     pullRequestCheckViewModel.Status = checkStatus;
                     pullRequestCheckViewModel.DetailsUrl = new Uri(arg.checkRun.DetailsUrl);
                     return pullRequestCheckViewModel;
@@ -136,9 +147,15 @@ private void DoOpenDetailsUrl()
             usageTracker.IncrementCounter(expression).Forget();
         }
 
+        /// <inheritdoc/>
+        public bool IsRequired { get; private set; }
+
         /// <inheritdoc/>
         public string Title { get; private set; }
 
+        /// <inheritdoc/>
+        public string DurationStatus { get; private set; }
+
         /// <inheritdoc/>
         public string Description { get; private set; }
 

src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IPullRequestCheckViewModel.cs

@@ -10,6 +10,11 @@ namespace GitHub.ViewModels.GitHubPane
     /// </summary>
     public interface IPullRequestCheckViewModel: IViewModel
     {
+        /// <summary>
+        /// The flag to show this Status/Check is required.
+        /// </summary>
+        bool IsRequired { get; }
+
         /// <summary>
         /// The title of the Status/Check.
         /// </summary>
@@ -30,6 +35,11 @@ public interface IPullRequestCheckViewModel: IViewModel
         /// </summary>
         Uri DetailsUrl { get; }
 
+        /// <summary>
+        /// The amount of time this Status/Check took to run.
+        /// </summary>
+        string DurationStatus { get; }
+
         /// <summary>
         /// A command that opens the DetailsUrl in a browser.
         /// </summary>

src/GitHub.Exports/Extensions/TimeSpanExtensions.cs

@@ -0,0 +1,89 @@
+using System;
+using System.Globalization;
+
+namespace GitHub.UI.Converters
+{
+    public static class TimeSpanExtensions
+    {
+        public static string Humanize(TimeSpan duration, CultureInfo culture, OutputTense outputTense = OutputTense.Past)
+        {
+            if (duration.Ticks <= 0)
+            {
+                return Resources.JustNow;
+            }
+
+            const int year = 365;
+            const int month = 30;
+            const int day = 24;
+            const int hour = 60;
+            const int minute = 60;
+
+            if (duration.TotalDays >= year)
+            {
+                return GetFormattedValue(culture, (int) (duration.TotalDays / year), 
+                    outputTense,
+                    Resources.YearsAgo, Resources.Years,
+                    Resources.YearAgo, Resources.Year);
+            }
+
+            if (duration.TotalDays >= 360)
+            {
+                return string.Format(culture, outputTense == OutputTense.Past ? Resources.MonthsAgo : Resources.Month, 11);
+            }
+
+            if (duration.TotalDays >= month)
+            {
+                return GetFormattedValue(culture, (int)(duration.TotalDays / month),
+                    outputTense,
+                    Resources.MonthsAgo, Resources.Months,
+                    Resources.MonthAgo, Resources.Month);
+            }
+
+            if (duration.TotalHours >= day)
+            {
+                return GetFormattedValue(culture, (int)(duration.TotalHours / day),
+                    outputTense,
+                    Resources.DaysAgo, Resources.Days,
+                    Resources.DayAgo, Resources.Day);
+            }
+
+            if (duration.TotalMinutes >= hour)
+            {
+                return GetFormattedValue(culture, (int)(duration.TotalMinutes / hour),
+                    outputTense,
+                    Resources.HoursAgo, Resources.Hours,
+                    Resources.HourAgo, Resources.Hour);
+            }
+
+            if (duration.TotalSeconds >= minute)
+            {
+                return GetFormattedValue(culture, (int)(duration.TotalSeconds / minute),
+                    outputTense,
+                    Resources.MinutesAgo, Resources.Minutes,
+                    Resources.MinuteAgo, Resources.Minute);
+            }
+
+            return GetFormattedValue(culture, (int) duration.TotalSeconds,
+                outputTense,
+                Resources.SecondsAgo, Resources.Seconds,
+                Resources.SecondAgo, Resources.Second);
+        }
+
+        private static string GetFormattedValue(CultureInfo culture, int value, OutputTense outputTense,
+            string multiplePast, string multipleCompleted,
+            string singlePast, string singleCompleted)
+        {
+            var formatString = value > 1
+                ? outputTense == OutputTense.Past ? multiplePast : multipleCompleted
+                : outputTense == OutputTense.Past ? singlePast : singleCompleted;
+
+            return string.Format(culture, formatString, value);
+        }
+
+        public enum OutputTense
+        {
+            Past,
+            Completed
+        }
+    }
+}

src/GitHub.Exports/GitHub.Exports.csproj

@@ -20,6 +20,7 @@
     <ProjectReference Include="..\..\submodules\octokit.net\Octokit\Octokit.csproj" />
     <ProjectReference Include="..\GitHub.Extensions\GitHub.Extensions.csproj" />
     <ProjectReference Include="..\GitHub.Logging\GitHub.Logging.csproj" />
+    <ProjectReference Include="..\GitHub.Resources\GitHub.Resources.csproj" />
   </ItemGroup>
 
   <ItemGroup>

src/GitHub.Exports/Models/CheckRunModel.cs

@@ -23,6 +23,11 @@ public class CheckRunModel
         /// </summary>
         public CheckStatusState Status { get; set; }
 
+        /// <summary>
+        /// Identifies the date and time when the check run was started.
+        /// </summary>
+        public DateTimeOffset? StartedAt { get; set; }
+
         /// <summary>
         /// Identifies the date and time when the check run was completed.
         /// </summary>
@@ -43,11 +48,21 @@ public class CheckRunModel
         /// </summary>
         public string DetailsUrl { get; set; }
 
+        /// <summary>
+        /// The title of a Check Run.
+        /// </summary>
+        public string Title { get; set; }
+
         /// <summary>
         /// The summary of a Check Run.
         /// </summary>
         public string Summary { get; set; }
 
+        /// <summary>
+        /// The flag to shows this Check Run is required.
+        /// </summary>
+        public bool IsRequired { get; set; }
+
         /// <summary>
         /// The detail of a Check Run.
         /// </summary>

src/GitHub.Exports/Models/ProtectedBranch.cs

@@ -0,0 +1,8 @@
+namespace GitHub.Models
+{
+    public class ProtectedBranch
+    {
+        public string Name { get; set; }
+        public string[] RequiredStatusCheckContexts { get; set; }
+    }
+}

src/GitHub.Exports/Models/StatusModel.cs

@@ -24,5 +24,10 @@ public class StatusModel
         /// The descritption for the Status
         /// </summary>
         public string Description { get; set; }
+
+        /// <summary>
+        /// The flag to shows this Status is required.
+        /// </summary>
+        public bool IsRequired { get; set; }
     }
 }

src/GitHub.Exports/Services/IRepositoryService.cs

@@ -1,5 +1,7 @@
 using System;
+using System.Collections.Generic;
 using System.Threading.Tasks;
+using GitHub.Models;
 using GitHub.Primitives;
 
 namespace GitHub.Services
@@ -17,5 +19,24 @@ public interface IRepositoryService
         /// otherwise null.
         /// </returns>
         Task<(string owner, string name)?> FindParent(HostAddress address, string owner, string name);
+
+        /// <summary>
+        /// Gets the list of protected branches.
+        /// </summary>
+        /// <param name="address">The host address.</param>
+        /// <param name="owner">The repository owner.</param>
+        /// <param name="name">The repository name.</param>
+        /// <returns></returns>
+        Task<IList<ProtectedBranch>> GetProtectedBranches(HostAddress address, string owner, string name);
+
+        /// <summary>
+        /// Gets the protected branch configuration of a particular branch, if any.
+        /// </summary>
+        /// <param name="address">The host address.</param>
+        /// <param name="owner">The repository owner.</param>
+        /// <param name="name">The repository name.</param>
+        /// <param name="branchName"></param>
+        /// <returns></returns>
+        Task<ProtectedBranch> GetProtectedBranch(HostAddress address, string owner, string name, string branchName);
     }
 }