test(core): the PROJ-H3b anti-vacuity control demands a third getActor call - #170
Merged
Merged
Conversation
…r call, not a second The control asserted `getActorCalls > 1` to prove that the "Nothing to commit" guard polled before concluding the actor was absent. That threshold was miscalibrated: addActor reads getActor once unconditionally (the existence check at the top of the method) and the guard reads once more before it ever enters its poll loop, so a guard WITHOUT a poll already produces two calls and satisfied the old assertion. Measured with a negative control: making the actor visible on the second read (poll never exercised) gives exactly `Received: 2` — green under `> 1`, red under `> 2`. The threshold is now `> 2`, with the calibration written next to it. Registered in the project_module audit (Task 1.2g, ears_test + dependency findings on PROJ-H3b); this closes it. 44/44.
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
PROJ-H3banti-vacuity control demanded a secondgetActorcall, but the behavior it guards only becomes observable on the third call. The test now asserts the third call, so it fails when the guarded behavior is removed and passes when it is present.Verification
project_modulesuite green with the control in place; the assertion goes red when the guarded call is removed.