Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply consistent 2 decimal places in UI. #3715

Merged

Conversation

eben619
Copy link
Contributor

@eben619 eben619 commented Oct 26, 2024

Fixes: #3607

Description

This PR addresses the Cosmetic UI issue to ensure all figures displayed contain 2 decimal places for consistency on the frontend.

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.
  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?

Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 6:53pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 6:53pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 6:53pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 6:53pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 6:53pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 6:53pm

@Chief1934
Copy link

https://medium.com/@chiefok13FINCEN/yeshua-gnik-0911be09e1ef?sk=f377672746bdfb7950caa1aa19d89db9Listen to Deep Vibes EP14 "Amir SISI" ArioSession 108, a playlist by SoundCloud on #SoundCloud
https://on.soundcloud.com/CkF91hak_9rYXZ0_bf9936ef781dc174c1123aea506c83cefecf3b1930e4d97951340e81d83dda2dRequest Id: 8603c369-b27e-4355-aa5d-780e2a154e00
Correlation Id: 4b7bd6e4-70e1-48c2-b0c2-232e60dc1816
Timestamp: 2024-10-19T17:51:07Z
Message: AADSTS50020: User account '[email protected]' from identity provider 'live.com' does not exist in tenant 'Aylo' and cannot access the application 'https://mindgeek.zendesk.com'(Zendesk Mindgeek) in that tenant. The account needs to be added as an external user in the tenant first. Sign out and sign in again with a different Azure Active Directory user account.1201 Roxas Blvd, Ermita, Manila, 1000 Metro Manila, Philippineschiefok13FINCENhttps://www.bandlab.com/join/kbzbuw9DGrPHA3j3YqHn6cVqaSU8vkLS3xhRfrdrm

@thelostone-mc thelostone-mc merged commit 0d69d9b into gitcoinco:main Oct 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmetic UI: display figures to always contain 2 decimal places for consistency
3 participants