Skip to content

Conversation

@PavelLaptev
Copy link
Contributor

@PavelLaptev PavelLaptev commented Oct 17, 2025

image

@PavelLaptev
Copy link
Contributor Author

@krlvi I just hardcoded the default threshold amount in the frontend, but there’s the same hardcoded default value in Rust.
Is there a good way to bind these defaults and use a single source?

pub fn snapshot_lines_threshold(&self) -> usize {
    self.snapshot_lines_threshold.unwrap_or(20)
}

@krlvi
Copy link
Member

krlvi commented Oct 18, 2025

the app doesnt do this anymore so this can be removed from the UI entirely

@PavelLaptev
Copy link
Contributor Author

The branch was corrupted and is in a weird state now. I'll leave it unchanged so we can investigate the issue later. I'll create another PR for this.

@Byron
Copy link
Collaborator

Byron commented Oct 21, 2025

@PavelLaptev Please keep a copy of the folder around if still possible 😅, it's probably something to investigate.

@PavelLaptev
Copy link
Contributor Author

@Byron yep. I wouldn't remove the branch :-)

@gitbutlerapp gitbutlerapp deleted a comment from vercel bot Oct 22, 2025
@Byron
Copy link
Collaborator

Byron commented Oct 22, 2025

Great, thanks, let's see what we can sort out in office then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants