Adding declarations so Alpaca is never referenced from Global scope #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow Alpaca to be used in environments with stricter evaluation
ambischof
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several places where
Alpacawas references without first declaringvar Alpaca = $.alpaca;so I added this declaration where it was absent. This will allow Alpaca to be used in environments withoutwindow.It currently seems to work fine in the browser, due to assigning it directly to
window, But we have been unable to use Alpaca in our unit tests because it won't run on node where there's no window. After these modifications, I was able to get it to work.