Refactor/rm computer monitor #2088
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have to admit that the new look does not tickle my fancy... But then, I had no problem with the monitor, either. @To1ne do you prefer the new look? If so, I won't object against merging. |
Well, me neither. For me this makes it more obvious what the latest release is, so that is good. (or maybe my brain was trained to ignore the computer monitor already, that's also possible). Maybe it's just the empty space that's making it weird. Can you move the other links up? And maybe make the Pro Git section full width? |
To1ne
reviewed
Sep 26, 2025
| } | ||
|
|
||
| .monitor { | ||
| @include background-image-2x($baseurl + "images/monitor-default", $monitor-width, $monitor-height); |
There was a problem hiding this comment.
Also remove the assets if we don't need them no more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #2068
Context
After the remove of the Background image, the monitor tag looks like this:
I opted to have the tag still to have the name
monitorsince it contains different details such as latest Git version, Binary links for different operating systems and the release date for the latest Git version.One thing I wasn't sure of was whether to remove the images from the repository, would love to hear your thoughts on this.