-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fixed: ordering of videos has been fixed at: /videos to show episodes in correct order #2084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Paulie-Aditya
wants to merge
5
commits into
git:gh-pages
Choose a base branch
from
Paulie-Aditya:fix/video-order
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−43
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c01cff5
fixed: ordering of videos has been fixed at: /videos to show episodes…
Paulie-Aditya dbbfa35
replacing two column approach with video grid
Paulie-Aditya 404e27e
testing for smaller screens
Paulie-Aditya 200ae6a
updating for smaller screens
Paulie-Aditya 62a4bc9
reverting some unnecessary changes
Paulie-Aditya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,17 +68,48 @@ aside { | |
border: solid 1px var(--main-border); | ||
@include border-radius(5px); | ||
|
||
.two-column { | ||
@include clearfix; | ||
|
||
.column-left { | ||
width: 47%; | ||
float: left; | ||
.video-grid { | ||
padding: 1rem 0; | ||
|
||
.video-thumbnails { | ||
display: grid; | ||
grid-template-columns: 1fr; | ||
gap: 2rem; | ||
list-style: none; | ||
padding: 0; | ||
margin: 0; | ||
|
||
@media (min-width: 600px) { | ||
grid-template-columns: repeat(auto-fit, minmax(300px, 1fr)); | ||
} | ||
} | ||
|
||
.column-right { | ||
width: 47%; | ||
float: right; | ||
.video-card { | ||
display: flex; | ||
flex-direction: column; | ||
text-decoration: none; | ||
color: inherit; | ||
height: 100%; | ||
transition: transform 0.2s ease; | ||
|
||
&:hover { | ||
transform: translateY(-3px); | ||
} | ||
|
||
img { | ||
width: 100%; | ||
height: auto; | ||
aspect-ratio: 16/9; | ||
object-fit: cover; | ||
} | ||
|
||
h4 { | ||
margin: 0.75rem 0; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
.description { | ||
margin-top: auto; | ||
} | ||
} | ||
} | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We better also add
box-sizing: border-box
due to this.