Skip to content

Commit

Permalink
reftable/generic: move seeking of records into the iterator
Browse files Browse the repository at this point in the history 
Reftable iterators are created by seeking on the parent structure of a
corresponding record. For example, to create an iterator for the merged
table you would call `reftable_merged_table_seek_ref()`. Most notably,
it is not posible to create an iterator and then seek it afterwards.

While this may be a bit easier to reason about, it comes with two
significant downsides. The first downside is that the logic to find
records is split up between the parent data structure and the iterator
itself. Conceptually, it is more straight forward if all that logic was
contained in a single place, which should be the iterator.

The second and more significant downside is that it is impossible to
reuse iterators for multiple seeks. Whenever you want to look up a
record, you need to re-create the whole infrastructure again, which is
quite a waste of time. Furthermore, it is impossible to optimize seeks,
such as when seeking the same record multiple times.

To address this, we essentially split up the concerns properly such that
the parent data structure is responsible for setting up the iterator via
a new `init_iter()` callback, whereas the iterator handles seeks via a
new `seek()` callback. This will eventually allow us to call `seek()` on
the iterator multiple times, where every iterator can potentially
optimize for certain cases.

Note that at this point in time we are not yet ready to reuse the
iterators. This will be left for a future patch series.

Signed-off-by: Patrick Steinhardt <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
@pks-t @gitster
pks-t authored and gitster committed May 14, 2024
1 parent 701713a commit 5bf96e0
Show file tree
Hide file tree
Showing 5 changed files with 177 additions and 117 deletions.
47 changes: 36 additions & 11 deletions reftable/generic.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,25 +12,39 @@ license that can be found in the LICENSE file or at
#include "reftable-iterator.h"
#include "reftable-generic.h"

void table_init_iter(struct reftable_table *tab,
struct reftable_iterator *it,
uint8_t typ)
{

tab->ops->init_iter(tab->table_arg, it, typ);
}

int reftable_table_seek_ref(struct reftable_table *tab,
struct reftable_iterator *it, const char *name)
{
struct reftable_record rec = { .type = BLOCK_TYPE_REF,
.u.ref = {
.refname = (char *)name,
} };
return tab->ops->seek_record(tab->table_arg, it, &rec);
struct reftable_record want = {
.type = BLOCK_TYPE_REF,
.u.ref = {
.refname = (char *)name,
},
};
table_init_iter(tab, it, BLOCK_TYPE_REF);
return it->ops->seek(it->iter_arg, &want);
}

int reftable_table_seek_log(struct reftable_table *tab,
struct reftable_iterator *it, const char *name)
{
struct reftable_record rec = { .type = BLOCK_TYPE_LOG,
.u.log = {
.refname = (char *)name,
.update_index = ~((uint64_t)0),
} };
return tab->ops->seek_record(tab->table_arg, it, &rec);
struct reftable_record want = {
.type = BLOCK_TYPE_LOG,
.u.log = {
.refname = (char *)name,
.update_index = ~((uint64_t)0),
},
};
table_init_iter(tab, it, BLOCK_TYPE_LOG);
return it->ops->seek(it->iter_arg, &want);
}

int reftable_table_read_ref(struct reftable_table *tab, const char *name,
Expand Down Expand Up @@ -152,11 +166,21 @@ int reftable_iterator_next_log(struct reftable_iterator *it,
return err;
}

int iterator_seek(struct reftable_iterator *it, struct reftable_record *want)
{
return it->ops->seek(it->iter_arg, want);
}

int iterator_next(struct reftable_iterator *it, struct reftable_record *rec)
{
return it->ops->next(it->iter_arg, rec);
}

static int empty_iterator_seek(void *arg, struct reftable_record *want)
{
return 0;
}

static int empty_iterator_next(void *arg, struct reftable_record *rec)
{
return 1;
Expand All @@ -167,6 +191,7 @@ static void empty_iterator_close(void *arg)
}

static struct reftable_iterator_vtable empty_vtable = {
.seek = &empty_iterator_seek,
.next = &empty_iterator_next,
.close = &empty_iterator_close,
};
Expand Down
9 changes: 7 additions & 2 deletions reftable/generic.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,24 @@ license that can be found in the LICENSE file or at

/* generic interface to reftables */
struct reftable_table_vtable {
int (*seek_record)(void *tab, struct reftable_iterator *it,
struct reftable_record *);
void (*init_iter)(void *tab, struct reftable_iterator *it, uint8_t typ);
uint32_t (*hash_id)(void *tab);
uint64_t (*min_update_index)(void *tab);
uint64_t (*max_update_index)(void *tab);
};

void table_init_iter(struct reftable_table *tab,
struct reftable_iterator *it,
uint8_t typ);

struct reftable_iterator_vtable {
int (*seek)(void *iter_arg, struct reftable_record *want);
int (*next)(void *iter_arg, struct reftable_record *rec);
void (*close)(void *iter_arg);
};

void iterator_set_empty(struct reftable_iterator *it);
int iterator_seek(struct reftable_iterator *it, struct reftable_record *want);
int iterator_next(struct reftable_iterator *it, struct reftable_record *rec);

#endif
15 changes: 15 additions & 0 deletions reftable/iter.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ static void filtering_ref_iterator_close(void *iter_arg)
reftable_iterator_destroy(&fri->it);
}

static int filtering_ref_iterator_seek(void *iter_arg,
struct reftable_record *want)
{
struct filtering_ref_iterator *fri = iter_arg;
return iterator_seek(&fri->it, want);
}

static int filtering_ref_iterator_next(void *iter_arg,
struct reftable_record *rec)
{
Expand Down Expand Up @@ -73,6 +80,7 @@ static int filtering_ref_iterator_next(void *iter_arg,
}

static struct reftable_iterator_vtable filtering_ref_iterator_vtable = {
.seek = &filtering_ref_iterator_seek,
.next = &filtering_ref_iterator_next,
.close = &filtering_ref_iterator_close,
};
Expand Down Expand Up @@ -119,6 +127,12 @@ static int indexed_table_ref_iter_next_block(struct indexed_table_ref_iter *it)
return 0;
}

static int indexed_table_ref_iter_seek(void *p, struct reftable_record *want)
{
BUG("seeking indexed table is not supported");
return -1;
}

static int indexed_table_ref_iter_next(void *p, struct reftable_record *rec)
{
struct indexed_table_ref_iter *it = p;
Expand Down Expand Up @@ -175,6 +189,7 @@ int new_indexed_table_ref_iter(struct indexed_table_ref_iter **dest,
}

static struct reftable_iterator_vtable indexed_table_ref_iter_vtable = {
.seek = &indexed_table_ref_iter_seek,
.next = &indexed_table_ref_iter_next,
.close = &indexed_table_ref_iter_close,
};
Expand Down
97 changes: 49 additions & 48 deletions reftable/merged.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,18 @@ struct merged_iter {
};

static void merged_iter_init(struct merged_iter *mi,
struct reftable_merged_table *mt)
struct reftable_merged_table *mt,
uint8_t typ)
{
memset(mi, 0, sizeof(*mi));
mi->advance_index = -1;
mi->suppress_deletions = mt->suppress_deletions;

REFTABLE_CALLOC_ARRAY(mi->subiters, mt->stack_len);
for (size_t i = 0; i < mt->stack_len; i++) {
reftable_record_init(&mi->subiters[i].rec, typ);
table_init_iter(&mt->stack[i], &mi->subiters[i].iter, typ);
}
mi->stack_len = mt->stack_len;
}

Expand Down Expand Up @@ -68,6 +74,27 @@ static int merged_iter_advance_subiter(struct merged_iter *mi, size_t idx)
return 0;
}

static int merged_iter_seek(struct merged_iter *mi, struct reftable_record *want)
{
int err;

mi->advance_index = -1;

for (size_t i = 0; i < mi->stack_len; i++) {
err = iterator_seek(&mi->subiters[i].iter, want);
if (err < 0)
return err;
if (err > 0)
continue;

err = merged_iter_advance_subiter(mi, i);
if (err < 0)
return err;
}

return 0;
}

static int merged_iter_next_entry(struct merged_iter *mi,
struct reftable_record *rec)
{
Expand Down Expand Up @@ -133,6 +160,11 @@ static int merged_iter_next_entry(struct merged_iter *mi,
return 0;
}

static int merged_iter_seek_void(void *it, struct reftable_record *want)
{
return merged_iter_seek(it, want);
}

static int merged_iter_next_void(void *p, struct reftable_record *rec)
{
struct merged_iter *mi = p;
Expand All @@ -147,6 +179,7 @@ static int merged_iter_next_void(void *p, struct reftable_record *rec)
}

static struct reftable_iterator_vtable merged_iter_vtable = {
.seek = merged_iter_seek_void,
.next = &merged_iter_next_void,
.close = &merged_iter_close,
};
Expand Down Expand Up @@ -220,47 +253,13 @@ reftable_merged_table_min_update_index(struct reftable_merged_table *mt)
return mt->min;
}

static int reftable_table_seek_record(struct reftable_table *tab,
struct reftable_iterator *it,
struct reftable_record *rec)
{
return tab->ops->seek_record(tab->table_arg, it, rec);
}

static int merged_table_seek_record(struct reftable_merged_table *mt,
struct reftable_iterator *it,
struct reftable_record *rec)
static void merged_table_init_iter(struct reftable_merged_table *mt,
struct reftable_iterator *it,
uint8_t typ)
{
struct merged_iter merged, *p;
int err;

merged_iter_init(&merged, mt);

for (size_t i = 0; i < mt->stack_len; i++) {
reftable_record_init(&merged.subiters[i].rec,
reftable_record_type(rec));

err = reftable_table_seek_record(&mt->stack[i],
&merged.subiters[i].iter, rec);
if (err < 0)
goto out;
if (err > 0)
continue;

err = merged_iter_advance_subiter(&merged, i);
if (err < 0)
goto out;
}

p = reftable_malloc(sizeof(*p));
*p = merged;
iterator_from_merged_iter(it, p);
err = 0;

out:
if (err < 0)
merged_iter_close(&merged);
return err;
struct merged_iter *mi = reftable_malloc(sizeof(*mi));
merged_iter_init(mi, mt, typ);
iterator_from_merged_iter(it, mi);
}

int reftable_merged_table_seek_ref(struct reftable_merged_table *mt,
Expand All @@ -273,7 +272,8 @@ int reftable_merged_table_seek_ref(struct reftable_merged_table *mt,
.refname = (char *)name,
},
};
return merged_table_seek_record(mt, it, &rec);
merged_table_init_iter(mt, it, BLOCK_TYPE_REF);
return iterator_seek(it, &rec);
}

int reftable_merged_table_seek_log_at(struct reftable_merged_table *mt,
Expand All @@ -285,7 +285,8 @@ int reftable_merged_table_seek_log_at(struct reftable_merged_table *mt,
.refname = (char *)name,
.update_index = update_index,
} };
return merged_table_seek_record(mt, it, &rec);
merged_table_init_iter(mt, it, BLOCK_TYPE_LOG);
return iterator_seek(it, &rec);
}

int reftable_merged_table_seek_log(struct reftable_merged_table *mt,
Expand All @@ -301,11 +302,11 @@ uint32_t reftable_merged_table_hash_id(struct reftable_merged_table *mt)
return mt->hash_id;
}

static int reftable_merged_table_seek_void(void *tab,
struct reftable_iterator *it,
struct reftable_record *rec)
static void reftable_merged_table_init_iter_void(void *tab,
struct reftable_iterator *it,
uint8_t typ)
{
return merged_table_seek_record(tab, it, rec);
merged_table_init_iter(tab, it, typ);
}

static uint32_t reftable_merged_table_hash_id_void(void *tab)
Expand All @@ -324,7 +325,7 @@ static uint64_t reftable_merged_table_max_update_index_void(void *tab)
}

static struct reftable_table_vtable merged_table_vtable = {
.seek_record = reftable_merged_table_seek_void,
.init_iter = reftable_merged_table_init_iter_void,
.hash_id = reftable_merged_table_hash_id_void,
.min_update_index = reftable_merged_table_min_update_index_void,
.max_update_index = reftable_merged_table_max_update_index_void,
Expand Down
Loading

0 comments on commit 5bf96e0

Please sign in to comment.