Skip to content

Conversation

@ecarreras
Copy link
Member

@ecarreras ecarreras commented Nov 5, 2025

This pull request adds support for a new progressbar attribute to indicator graphs, allowing them to display a progress bar based on the value and total. The implementation includes updates to the IndicatorGraph class to parse and expose the new attribute, modifies the processing logic to handle progress bar display, and adds comprehensive tests to verify the new behavior.

Indicator graph enhancements:

  • Added support for a progressbar attribute in the IndicatorGraph class, including parsing the attribute from XML and exposing it as a property. [1] [2]
  • Updated the process method to include the progressbar key in the result when applicable, and to ensure the percent value is included when either progressbar or showPercent is true.

Testing improvements:

  • Expanded the test suite in graph_spec.py to cover the new progressbar attribute, including its interaction with the percent value and different combinations of attributes.

Related

- Include progressbar in result when it's set to True
- Update tests to verify progressbar property in result
@ecarreras ecarreras self-assigned this Nov 5, 2025
@ecarreras ecarreras requested a review from polsala November 5, 2025 17:20
@ecarreras ecarreras added the minor Create a Minor version label Nov 5, 2025
@ecarreras ecarreras merged commit e59ad5e into main Nov 5, 2025
1 check passed
@ecarreras ecarreras deleted the 80812/add-progressbar-to-indicator branch November 5, 2025 17:21
@ecarreras ecarreras restored the 80812/add-progressbar-to-indicator branch November 5, 2025 17:21
@ecarreras ecarreras deleted the 80812/add-progressbar-to-indicator branch November 20, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Create a Minor version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants