Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mako as default value of the template language #180

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

JSebasGL
Copy link
Contributor

@JSebasGL JSebasGL commented Mar 5, 2025

New performance

With the function of creating a new template, a default value is added in the Expression builder, specifically in the Templating Language, Mako Templates will be assigned to it.

Past performance

mako_default_value_of_template

New performance

mako_default_value_of_template2

@JSebasGL JSebasGL added this to the v23.12 milestone Mar 5, 2025
@JSebasGL JSebasGL self-assigned this Mar 5, 2025
gpozo-gisce
gpozo-gisce previously approved these changes Mar 5, 2025
@ecarreras
Copy link
Member

@lcbautista nosé com ho veieu però fins i tot, podem eliminar el llenguatge de la plantilla? sempre hem fet servir mako i així també podem treure el try/except que mirar si hi ha el django templates?

@lcbautista
Copy link
Member

@lcbautista nosé com ho veieu però fins i tot, podem eliminar el llenguatge de la plantilla? sempre hem fet servir mako i així també podem treure el try/except que mirar si hi ha el django templates?

Em sembla bé. De moment mergejo això i creo una tasca a part per analitzar que hem de fer.

Copy link

github-actions bot commented Mar 5, 2025

PY2TestsResults

 2 files   2 suites   1m 55s ⏱️
92 tests 92 ✅ 0 💤 0 ❌
93 runs  93 ✅ 0 💤 0 ❌

Results for commit 21fd917.

@lcbautista lcbautista merged commit 355eb91 into v5_backport Mar 5, 2025
4 of 5 checks passed
@lcbautista lcbautista deleted the 70561_mako_default_value_of_templates branch March 5, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants