Registrar error cuando falla el proceso de renderizar email #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eberloso
previously approved these changes
Mar 4, 2025
MarcCalvoC
force-pushed
the
log_error_when_email_rendering_fails
branch
from
50b2891 to
6fef33d
Compare
There was a problem hiding this comment.
PR Overview
This PR introduces error logging when email template rendering fails, enabling better tracking of issues with incorrect templates.
- Adds sentry_sdk import for error capture.
- Captures and logs a warning message when an exception is raised during template rendering.
Reviewed Changes
| File | Description |
|---|---|
| poweremail_template.py | Integrates Sentry logging into the exception handling block. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
| @@ -225,6 +226,8 @@ def get_value(cursor, user, recid, message=None, template=None, context=None): | |||
| reply = False | |||
| return reply or False | |||
| except Exception as e: | |||
| msg = (_('An error occurred while rendering template id {}: {}'.format(template.id, e.message))) | |||
There was a problem hiding this comment.
Using 'e.message' may not reliably capture exception details in Python 3; consider using 'str(e)' instead to ensure full error information is logged.
Suggested change
| msg = (_('An error occurred while rendering template id {}: {}'.format(template.id, e.message))) | |
| msg = (_('An error occurred while rendering template id {}: {}'.format(template.id, str(e)))) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objetivos
Poder llevar un seguimiento de los emails que no se pueden renderizar para detectar plantillas incorrectas