Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag: allow colorField to define color for tag #172

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

ecarreras
Copy link
Member

This pull request includes changes to the Field and Tag classes to add new properties and methods, as well as updates to the test suite for the Tag class to cover the new functionality.

Enhancements to Field class:

  • Added a private _raw_props property and a corresponding raw_props getter to store the raw properties passed to the constructor. (src/Field.ts)

Enhancements to Tag class:

  • Added a colorField getter to retrieve the colorField property from the widget properties. (src/Tag.ts)

Updates to Tag class tests:

  • Added tests to ensure the colorField property is correctly set to null by default and properly parsed when provided. (src/spec/Tag.spec.ts)

@ecarreras ecarreras added the enhancement New feature or request label Feb 6, 2025
@ecarreras ecarreras merged commit 14ff888 into v2 Feb 6, 2025
1 check passed
@ecarreras ecarreras deleted the 69649/tag-field-color branch February 6, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant