Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new carousel widget container #153

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Add new carousel widget container #153

merged 2 commits into from
Dec 12, 2024

Conversation

ecarreras
Copy link
Member

@ecarreras ecarreras commented Dec 11, 2024

This pull request introduces a new Carousel widget to the codebase, along with the necessary integration and tests. The main changes include the implementation of the Carousel class, updates to the WidgetFactory to support the new widget, and the addition of tests to ensure the Carousel functions correctly.

Implementation of Carousel widget:

  • src/Carousel.ts: Added the Carousel class, which extends ContainerWidget and includes properties and methods for autoPlay and items. The constructor allows setting autoPlay via properties.

Integration with WidgetFactory:

  • src/WidgetFactory.ts: Imported the Carousel class and updated the WidgetFactory to create a Carousel widget when the type is "carousel". [1] [2]

Exporting the Carousel widget:

  • src/index.ts: Imported and exported the Carousel class to make it available for use in other parts of the application. [1] [2]

Testing the Carousel widget:

  • src/spec/Carousel.spec.ts: Added tests for the Carousel widget to verify its creation, default autoPlay value, ability to set autoPlay, and correct handling of items within groups.

@ecarreras ecarreras added the enhancement New feature or request label Dec 11, 2024
@ecarreras ecarreras self-assigned this Dec 11, 2024
@ecarreras ecarreras marked this pull request as ready for review December 11, 2024 15:42
@ecarreras ecarreras merged commit e6c03fc into v2 Dec 12, 2024
1 check passed
@ecarreras ecarreras deleted the carousel branch December 12, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants