Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow suffix and prefix #152

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Allow suffix and prefix #152

merged 1 commit into from
Dec 12, 2024

Conversation

ecarreras
Copy link
Member

This pull request includes several changes to enhance the handling of widget_props across different components and to improve the parsing of widget properties. The most important changes include the addition of new getter methods in the Field class, updates to the Form class to merge widget properties, and the creation of a new utility function for parsing widget properties.

Enhancements to widget_props handling:

  • src/Field.ts: Added suffix and prefix getter methods to the Field class to retrieve widget properties.

  • src/Form.ts: Updated imports to include parseWidgetProps and modified the Form class to merge widget_props from the fields definition and XML attributes. [1] [2]

  • src/Widget.ts: Updated the Widget class to use the new parseWidgetProps utility function for parsing widget_props. [1] [2]

Utility function creation:

Testing improvements:

  • src/spec/Form.spec.ts: Added a new test case to ensure that widget_props from fields definition and XML attributes are correctly merged.

@ecarreras ecarreras added the enhancement New feature or request label Dec 10, 2024
@ecarreras ecarreras self-assigned this Dec 10, 2024
@mguellsegarra mguellsegarra merged commit 83a3d33 into v2 Dec 12, 2024
1 check passed
@mguellsegarra mguellsegarra deleted the suffix-and-prefix branch December 12, 2024 13:40
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
# [2.23.0](v2.22.0...v2.23.0) (2024-12-12)

### Features

* **field:** allow suffix and prefix ([#152](#152)) ([83a3d33](83a3d33))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants