Merge branch 'feature/auto-refresh-field' into alpha

gisce · Dec 2, 2024 · b1d8797 · b1d8797
2 parents 7423fee + 91d2dd8
commit b1d8797
Show file tree

Hide file tree

Showing 7 changed files with 185 additions and 14 deletions.
diff --git a/src/Field.ts b/src/Field.ts
@@ -1,5 +1,6 @@
 import Widget from "./Widget";
 import { replaceEntities, isTrue } from "./helpers/attributeParser";
+import { parseBoolAttribute } from "./helpers/nodeParser";
 
 class Field extends Widget {
   /**
@@ -125,6 +126,27 @@ class Field extends Widget {
     return this._fieldType;
   }
 
+  _autoRefresh?: boolean = false;
+  get autoRefresh(): boolean {
+    return this._autoRefresh ?? false;
+  }
+
+  set autoRefresh(value: boolean) {
+    this._autoRefresh = value;
+  }
+
+  get readOnly(): boolean | undefined {
+    if (this.autoRefresh) {
+      return true;
+    } else {
+      return super.readOnly;
+    }
+  }
+
+  set readOnly(value: boolean | undefined) {
+    super.readOnly = value;
+  }
+
   constructor(props: any) {
     super(props);
 
@@ -180,6 +202,9 @@ class Field extends Widget {
       if (props.help_inline) {
         this.tooltipInline = isTrue(props.help_inline);
       }
+      if (props.autorefresh) {
+        this.autoRefresh = parseBoolAttribute(props.autorefresh);
+      }
     }
   }
 

diff --git a/src/Form.ts b/src/Form.ts
@@ -120,6 +120,14 @@ class Form {
     this._invisibleFields = value;
   }
 
+  /**
+   * List of autorefreshable fields
+   */
+  _autorefreshableFields: string[] = [];
+  get autorefreshableFields(): string[] {
+    return this._autorefreshableFields;
+  }
+
   /**
    * Context for each field in the form
    */
@@ -166,6 +174,11 @@ class Form {
         this._contextForFields[unknownWidget._id] = widget._context;
       }
     });
+
+    // Also we store all the autorefreshables fields in a list
+    this._autorefreshableFields = allWidgets
+      .filter((widget) => widget instanceof Field && widget.autoRefresh)
+      .map((field) => (field as Field)._id);
   }
 
   parseNode({

diff --git a/src/Widget.ts b/src/Widget.ts
@@ -1,4 +1,5 @@
 import { replaceEntities } from "./helpers/attributeParser";
+import { parseBoolAttribute } from "./helpers/nodeParser";
 
 abstract class Widget {
   /**
@@ -124,19 +125,7 @@ abstract class Widget {
         this._colspan = +props.colspan;
       }
       if (props.readonly !== undefined) {
-        if (
-          props.readonly === "1" ||
-          props.readonly === 1 ||
-          props.readonly === true
-        ) {
-          this._readOnly = true;
-        } else if (
-          props.readonly === "0" ||
-          props.readonly === 0 ||
-          props.readonly === false
-        ) {
-          this._readOnly = false;
-        }
+        this._readOnly = parseBoolAttribute(props.readonly);
       }
       if (props.invisible) {
         if (

diff --git a/src/helpers/nodeParser.ts b/src/helpers/nodeParser.ts
@@ -5,7 +5,13 @@ type ParsedNode = {
 };
 
 const parseBoolAttribute = (attr: any): boolean => {
-  if (attr === 1 || attr === "1" || attr === true || attr === "True") {
+  if (
+    attr === 1 ||
+    attr === "1" ||
+    attr === true ||
+    attr === "True" ||
+    attr === "true"
+  ) {
     return true;
   } else {
     return false;

diff --git a/src/spec/Field.spec.ts b/src/spec/Field.spec.ts
@@ -0,0 +1,35 @@
+import { describe, it, expect } from "vitest";
+import Field from "../Field";
+
+describe("Field", () => {
+  describe("with the autoRefresh property", () => {
+    it("should be false as default", () => {
+      const props = {};
+      const field = new Field(props);
+      expect(field.autoRefresh).toBe(false);
+    });
+    it("should work with text", () => {
+      const props = {
+        autorefresh: "1",
+      };
+      const field = new Field(props);
+      expect(field.autoRefresh).toBe(true);
+    });
+    describe("if autorefresh is not a valid boold", () => {
+      it("should return false", () => {
+        const props = {
+          autorefresh: "abc",
+        };
+        const field = new Field(props);
+        expect(field.autoRefresh).toBe(false);
+      });
+    });
+    it("should return true for readOnly if autoRefresh is set", () => {
+      const props = {
+        autorefresh: true,
+      };
+      const field = new Field(props);
+      expect(field.readOnly).toBe(true);
+    });
+  });
+});
diff --git a/src/spec/Form.spec.ts b/src/spec/Form.spec.ts
@@ -6015,4 +6015,54 @@ describe("A Form", () => {
     expect(field_char?.type).toBe("arrow_steps");
     expect(field_char?.id).toBe("field_char");
   });
+  it("a field with autorefresh evaluated in attrs should be present in form autorefreshable fields property", () => {
+    const fields = {
+      field_char: {
+        string: "Etapa",
+        type: "char",
+      },
+      state: {
+        readonly: true,
+        required: true,
+        selection: [
+          ["esborrany", "Borrador"],
+          ["validar", "Validar"],
+          ["pendent", "Pendiente"],
+          ["activa", "Activa"],
+          ["cancelada", "Cancelada"],
+          ["contracte", "Activación Contrato"],
+          ["novapolissa", "Creación nuevo contrato"],
+          ["modcontractual", "Modificación Contractual"],
+          ["impagament", "Impago"],
+          ["tall", "Corte"],
+          ["running", "En ejecución"],
+          ["baixa", "Baja"],
+          ["facturacio", "Facturación"],
+        ],
+        string: "Estado",
+        type: "selection",
+        views: {},
+      },
+    };
+
+    const xmlViewForm = `<?xml version="1.0"?>
+    <form string="Form1">
+    	<field name="field_char" widget="arrow_steps" colspan="4" nolabel="1" attrs="{'autorefresh':[('state', '=', 'running')]}" />
+    </form>`;
+
+    const form = new Form(fields);
+    form.parse(xmlViewForm, {
+      values: {
+        field_char: "test",
+        state: "running",
+      },
+    });
+
+    const field_char = form.findById("field_char") as Field;
+    expect(field_char).toBeDefined();
+    expect(field_char?.autoRefresh).toBeTruthy();
+    expect(field_char?.readOnly).toBeTruthy();
+    expect(form.autorefreshableFields.length).toBe(1);
+    expect(form.autorefreshableFields[0]).toBe("field_char");
+  });
 });
diff --git a/src/spec/nodeParser.spec.ts b/src/spec/nodeParser.spec.ts
@@ -0,0 +1,53 @@
+import { describe, it, expect } from "vitest";
+import { parseBoolAttribute } from "../helpers/nodeParser";
+
+describe("parseBoolAttribute", () => {
+  it("returns true for numeric 1", () => {
+    expect(parseBoolAttribute(1)).toBe(true);
+  });
+
+  it('returns true for string "1"', () => {
+    expect(parseBoolAttribute("1")).toBe(true);
+  });
+
+  it("returns true for boolean true", () => {
+    expect(parseBoolAttribute(true)).toBe(true);
+  });
+
+  it('returns true for string "True"', () => {
+    expect(parseBoolAttribute("True")).toBe(true);
+  });
+
+  it('returns true for string "true"', () => {
+    expect(parseBoolAttribute("true")).toBe(true);
+  });
+
+  it("returns false for numeric 0", () => {
+    expect(parseBoolAttribute(0)).toBe(false);
+  });
+
+  it('returns false for string "0"', () => {
+    expect(parseBoolAttribute("0")).toBe(false);
+  });
+
+  it("returns false for boolean false", () => {
+    expect(parseBoolAttribute(false)).toBe(false);
+  });
+
+  it('returns false for string "False"', () => {
+    expect(parseBoolAttribute("False")).toBe(false);
+  });
+
+  it("returns false for null", () => {
+    expect(parseBoolAttribute(null)).toBe(false);
+  });
+
+  it("returns false for undefined", () => {
+    expect(parseBoolAttribute(undefined)).toBe(false);
+  });
+
+  it("returns false for non-boolean strings", () => {
+    expect(parseBoolAttribute("yes")).toBe(false);
+    expect(parseBoolAttribute("no")).toBe(false);
+  });
+});