Merge pull request #82 from gisce/fix-label-size

Better define label size
gisce · May 24, 2023 · 85f6ab1 · 85f6ab1
2 parents c29d767 + 8ecf85d
commit 85f6ab1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@gisce/ooui",
-  "version": "0.19.3",
+  "version": "0.19.4",
   "main": "./dist/ooui.umd.js",
   "module": "./dist/ooui.es.js",
   "types": "./dist/index.d.ts",

diff --git a/src/Label.ts b/src/Label.ts
@@ -2,7 +2,7 @@ import Field from "./Field";
 
 
 type LabelType = "secondary" | "success" | "warning" | "danger" | "default";
-type LabelSize = "h1" | "h2" | "h3" | "h4" | "h5" | "text";
+type LabelSize = 1 | 2 | 3 | 4 | 5 | undefined;
 
 class Label extends Field {
   /**
@@ -41,7 +41,7 @@ class Label extends Field {
   /**
    * Label size
    */
-   _labelSize: LabelSize = "text";
+   _labelSize: LabelSize = undefined;
    get labelSize(): LabelSize {
      return this._labelSize;
    }

diff --git a/src/spec/Label.spec.ts b/src/spec/Label.spec.ts
@@ -75,15 +75,15 @@ describe("A Label", () => {
         widget_props: "{}"
       };
       const widget = widgetFactory.createWidget("label", props);
-      expect(widget.labelSize).toBe("text");
+      expect(widget.labelSize).toBe(undefined);
     });
     it("should have allow size to h1...h5", () => {
       const widgetFactory = new WidgetFactory();
-      ['h1', 'h2', 'h3', 'h4', 'h5'].map((level) => {
+      [1, 2, 3, 4, 5].map((level) => {
         const props = {
           name: "field_label",
           string: "Default",
-          widget_props: `{'label_size': '${level}'}`
+          widget_props: `{'label_size': ${level}}`
         };
         const widget = widgetFactory.createWidget("label", props);
         expect(widget.labelSize).toBe(level);