Merge pull request #146 from gisce/container-spinner

Allow loading in Page and Group components
gisce · Dec 9, 2024 · 2e4b523 · 2e4b523
2 parents a6c6a50 + 57c3f16
commit 2e4b523
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 4 deletions.
diff --git a/src/Group.ts b/src/Group.ts
@@ -1,6 +1,6 @@
-import ContainerWidget from "./ContainerWidget";
+import Spinner from "./Spinner";
 
-class Group extends ContainerWidget {
+class Group extends Spinner {
   _icon: string | null = null;
   get icon(): string | null {
     return this._icon;

diff --git a/src/Page.ts b/src/Page.ts
@@ -1,6 +1,6 @@
-import ContainerWidget from "./ContainerWidget";
+import Spinner from "./Spinner";
 
-class Page extends ContainerWidget {
+class Page extends Spinner {
   _icon: string | null = null;
   get icon(): string | null {
     return this._icon;

diff --git a/src/spec/Group.spec.ts b/src/spec/Group.spec.ts
@@ -40,4 +40,23 @@ describe("A Group", () => {
     const widget = widgetFactory.createWidget("group", props);
     expect(widget.icon).toEqual("home");
   });
+  describe("working as a spinner", () => {
+    it("should be loading false as default", () => {
+      const widgetFactory = new WidgetFactory();
+      const props = {
+        string: "A group",
+      };
+      const widget = widgetFactory.createWidget("group", props);
+      expect(widget.loading).toBe(false);
+    });
+    it("should be loading true if set", () => {
+      const widgetFactory = new WidgetFactory();
+      const props = {
+        string: "A group",
+        loading: true,
+      };
+      const widget = widgetFactory.createWidget("group", props);
+      expect(widget.loading).toBe(true);
+    });
+  });
 });
diff --git a/src/spec/Page.spec.ts b/src/spec/Page.spec.ts
@@ -14,4 +14,23 @@ describe("A Page", () => {
     expect(widget.label).toBe("Page 1");
     expect(widget.icon).toBe("home");
   });
+  describe("working as a Spinner", () => {
+    it("should have loading to be false by default", () => {
+      const widgetFactory = new WidgetFactory();
+      const props = {
+        string: "Page 1",
+      };
+      const widget = widgetFactory.createWidget("page", props);
+      expect(widget.loading).toBe(false);
+    });
+    it("should allow setting loading to true", () => {
+      const widgetFactory = new WidgetFactory();
+      const props = {
+        string: "Page 1",
+        loading: true,
+      };
+      const widget = widgetFactory.createWidget("page", props);
+      expect(widget.loading).toBe(true);
+    });
+  });
 });