Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Adapt to new CNMC F5D format #82

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[WIP] Adapt to new CNMC F5D format #82

wants to merge 2 commits into from

Conversation

Ruben1700
Copy link

@Ruben1700 Ruben1700 commented Dec 11, 2024 •
edited
Loading

Objetivos

  • Implementar los nuevos formatos marcados por la CNMC conforme al ATR 3.0

Comportamiento antiguo

  • Un único formato que queda obsoleto con la entrada en vigor de ATR 3.0

Comportamiento nuevo

  • Se ha adaptado el F5D para poder discernir entre el formato a generar (CNMC o REE):
    • Se han incluido nuevas magnitudes ai_fix y ao_fix.
    • Se han hecho modificaciones para incluir o no estas magnitudes según el formato a exportar.

Checklist

  • Test code

@Ruben1700 Ruben1700 self-assigned this Dec 11, 2024
@Ruben1700 Ruben1700 marked this pull request as draft December 11, 2024 10:36
@Ruben1700 Ruben1700 changed the title first approach: Adapt to new CNMC F5D format [WIP] Adapt to new CNMC F5D format Dec 11, 2024
@Ruben1700 Ruben1700 force-pushed the 65594_adapt_f5d_to_new_cnmc_format branch from 617f9de to 7069c3c Compare December 11, 2024 10:43
davidmunoznovoa
davidmunoznovoa requested changes Dec 11, 2024
View reviewed changes
mesures/f5d.py Outdated Show resolved Hide resolved
mesures/f5d.py Show resolved Hide resolved
@Ruben1700 Ruben1700 force-pushed the 65594_adapt_f5d_to_new_cnmc_format branch from 7069c3c to 60e57c8 Compare December 11, 2024 10:50
@Ruben1700 Ruben1700 force-pushed the 65594_adapt_f5d_to_new_cnmc_format branch from 60e57c8 to cee1980 Compare December 11, 2024 11:22
@Ruben1700 Ruben1700 marked this pull request as ready for review December 11, 2024 11:48
@Ruben1700 Ruben1700 marked this pull request as draft December 11, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmunoznovoa davidmunoznovoa davidmunoznovoa requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Ruben1700 Ruben1700

Labels
distri enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ruben1700 @davidmunoznovoa