Skip to content

solana pay response types#347

Merged
nickfrosty merged 7 commits intomasterfrom
solana-pay-post-response-types
Nov 16, 2025
Merged

solana pay response types#347
nickfrosty merged 7 commits intomasterfrom
solana-pay-post-response-types

Conversation

@nickfrosty
Copy link
Collaborator

Problem

the @gillsdk/solana-pay Transaction Request fetchers (fetchSolanaPayGetRequest and fetchSolanaPayPostRequest) return misleading or incorrect types since these fetchers auto call parser, returning a modified version of the original payload.

Summary of Changes

  • created a separate "parsed" type for each GET and POST payload, returning these "parsed payloads" from the parsers
  • added typechecks to ensure the attribute keys of the parsed and non-parsed types always match

@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2025

🦋 Changeset detected

Latest commit: d4cae7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@gillsdk/solana-pay Minor
@gillsdk/examples-basics Minor
@gillsdk/examples-tokens Minor
@gillsdk/tests-e2e Minor
@gillsdk/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bundlemon
Copy link

bundlemon bot commented Nov 15, 2025

BundleMon

Unchanged files (16)
Status Path Size Limits
gill/dist/programs/index.node.mjs
9.83KB -
gill/dist/index.browser.mjs
5.63KB -
gill/dist/index.native.mjs
5.63KB -
gill/dist/programs/token/index.node.mjs
4.11KB -
react/dist/index.browser.mjs
2.12KB -
react/dist/index.native.mjs
2.12KB -
react/dist/index.node.mjs
2.12KB -
solana-pay/dist/index.browser.mjs
1.98KB -
solana-pay/dist/index.native.mjs
1.98KB -
solana-pay/dist/index.node.mjs
1.98KB -
gill/dist/node/index.node.mjs
948B -
gill/dist/index.node.mjs
520B -
svelte/dist/index.browser.mjs
265B -
vue/dist/index.browser.mjs
265B -
svelte/dist/index.node.mjs
262B -
vue/dist/index.node.mjs
262B -

Total files change -1B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@nickfrosty nickfrosty merged commit c4430e5 into master Nov 16, 2025
5 checks passed
@nickfrosty nickfrosty deleted the solana-pay-post-response-types branch November 16, 2025 15:58
@github-actions github-actions bot mentioned this pull request Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant