[react]: add useSendTransaction hook

[JkrishnaD]

Problem

Implement the sendTransaction call as a hook

Summary of Changes

as mentioned in #167 to create a sendTransaction hook i have done

• i have added the useSendTransaction in hooks/send-transaction.ts
• added typeset file for send-transaction.ts - ensures type safety and correct response shapes for all supported encodings
• export the hook from main index.ts
• updated the react package README.md
• followed existing naming convention and changeset rules for consistency

[changeset-bot]

🦋 Changeset detected

Latest commit: d9dce41

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@gillsdk/react	Minor
@gillsdk/examples-basics	Minor
@gillsdk/examples-tokens	Minor
@gillsdk/tests-e2e	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[JkrishnaD]

@nickfrosty check this out once (my bad multiple commits in order to fix the changeset file)

[macalinao]

What's the benefit of using a mutation over something like useCallback, or adding this to createSolanaClient?

[JkrishnaD]

@macalinao here we used useMutation because it is a state changing rpc-call as we are sending the transaction on-chain which changes the state. so i have used it there

[GuiBibeau]

Hey! Nice work on this hook 🎉

Just noticed a small naming issue: the parameter signature in line 19 should probably be wireTransaction or transaction instead.

Currently it's a bit confusing because:

• We're passing IN a transaction (base64 encoded)
• We're getting OUT a signature (the transaction ID)

Using signature for the input makes it seem like we're passing in a signature, when we're actually passing in the whole transaction. What do you think about renaming it?

[JkrishnaD]

@GuiBibeau thanks for the review i'll make sure all the changes which are reviewed will be added by tomorrow

[nickfrosty]

The idea for this hook is good but the usage pattern is wrong...

Think about how a dev would actually use this hook as its currently written: you have to have the transaction already before even instantiating the hook. Which means you could only really uses this inside a guard component that has the transaction passed to it. That makes no sense.

Instead, developer usage should look something like this:

const { sendTransaction } = useSendTransaction({
      config: {
        encoding: "base64",
        preflightCommitment: "confirmed",
        skipPreflight: false,
      },
    });
    
    const signature = await sendTransaction(...validTransaction);

Please rework this hook to:

• rebase to master
• reword the hook as described above
• fix the imports in the files you added to use .js file extensions (see the other hooks and typeset tests)
• fix the incorrect readme entry (that does not even match how you would use this as currently written) to be correct for the updated usage
• remove your retry delay since it does not give users any flexibility of control
• remove your incorrect comment for return the transaction signature as a base-64 encoded string. its a Signature, which is a base58 encoded string

edit: this hook also needs to support the options and config, similarly to how all the other hooks accept them.

[JkrishnaD]

@nickfrosty I'm doing all the changes you mentioned.

questions: the edit you mentioned about the options and the config these are not defined for the useMutation in the gillRpc types so i'm thinking to define the mutationOptions in the hook itself.

thought: it is good to have them globally by defining them in the hooks/types.ts file

[tobeycodes]

It looks like no commits have been made since this comment so this is still a work in progress.

#229 (review)

[JkrishnaD]

@tobeycodes #229 (comment) for this question can you give the clarity for me

in this the types mentioned there are only for the useQuery hook they are not working for the useMutation which we are using in the sendTransaction.

Thinking: to add these types in the sendTransaction hook itself. i need the clarification on this.

[tobeycodes]

Nice work.

question: can you give me an example when you would use sendTransaction instead of signAndSendTransaction?

[tobeycodes]

For @nickfrosty to review