Parse dump-pif result and reduce XCBuildSupport dependency
#183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesyo
reviewed
Feb 28, 2025
Ryu0118
approved these changes
May 16, 2025
giginet
commented
May 20, 2025
Co-authored-by: IKEDA Sho <[email protected]>
ikesyo
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
swift package dump-pifto construct PIF instead of the internal implementation of SwiftPM.Using
dump-pifcommand, we can reduce dependency and we can use stable specs.Our final goal is to remove the
XCBuildSupportdependency.This PR introduces SwiftyJSON to manipulate PIFs. because it's tough to define a complete PIF using
Codable. We only need a subset of PIF.Instead, I concluded the JSON manipulation into the
PIFKittarget.ScipioKitcan manipulate PIF in type-safe.