forked from browser-use/browser-harness
-
Notifications
You must be signed in to change notification settings - Fork 0
dedup: import _load_env from helpers + add dupehound CI #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
giattijunior
wants to merge
2
commits into
main
Choose a base branch
from
dedup/dupehound-pass1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| name: dupehound | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'src/**' | ||
| - 'tests/**' | ||
| push: | ||
| branches: [main] | ||
| paths: | ||
| - 'src/**' | ||
| - 'tests/**' | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| check: | ||
| name: Block new duplicates | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| continue-on-error: true | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Install dupehound | ||
| run: | | ||
| curl -sL https://github.com/Rafaelpta/dupehound/releases/latest/download/dupehound-x86_64-unknown-linux-gnu.tar.gz | tar xz | ||
| sudo mv dupehound /usr/local/bin/ | ||
| - name: Block new duplicates vs base | ||
| env: | ||
| PR_BASE: ${{ github.event.pull_request.base.ref }} | ||
| run: | | ||
| if [ -n "$PR_BASE" ]; then | ||
| dupehound check --diff "origin/$PR_BASE" . | ||
| else | ||
| dupehound check --diff HEAD~1 . | ||
| fi | ||
|
|
||
| scan: | ||
| name: Repo slop score | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 | ||
| - name: Install dupehound | ||
| run: | | ||
| curl -sL https://github.com/Rafaelpta/dupehound/releases/latest/download/dupehound-x86_64-unknown-linux-gnu.tar.gz | tar xz | ||
| sudo mv dupehound /usr/local/bin/ | ||
| - name: Scan | ||
| run: | | ||
| dupehound scan . | tee /tmp/dh-scan.txt | ||
| SCORE=$(grep -oE 'SLOP SCORE[[:space:]]+[0-9.]+%' /tmp/dh-scan.txt | head -1 | grep -oE '[0-9.]+%' || echo "n/a") | ||
| echo "## dupehound slop score" >> "$GITHUB_STEP_SUMMARY" | ||
| echo "**${SCORE}**" >> "$GITHUB_STEP_SUMMARY" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Importing
.helpershere immediately runs its module-level_load_agent_helpers(), soagent-workspace/agent_helpers.pyis executed whilebrowser_harness.adminis only partially initialized. If a task helper imports an admin API such asfrom browser_harness.admin import start_remote_daemon, the CLI now fails with a circular-importImportErrorbefore any command runs; this worked before becauserun.pyloaded admin before loading helpers. Move the env loader to a side-effect-free module or defer agent-helper loading to the CLI helper path.Useful? React with 👍 / 👎.