Remove label for old slo framework (#393)

giantswarm · May 21, 2024 · e1064c8 · e1064c8
1 parent b60fce1
commit e1064c8
Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project's packages adheres to [Semantic Versioning](http://semver.org/s
 
 ## [Unreleased]
 
+### Removed
+
+- Remove `giantswarm.io/monitoring_basic_sli` label on the prometheus operator to get rid of the old slo alert mechanism.
+
 ### Changed
 
 - Upgraded chart dependency from kube-prometheus-stack-58.6.0 to [kube-prometheus-stack-58.6.0](https://github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-58.6.0)

diff --git a/helm/kube-prometheus-stack/values.schema.json b/helm/kube-prometheus-stack/values.schema.json
@@ -180,12 +180,6 @@
                 "kube-state-metrics": {
                     "type": "object",
                     "properties": {
-                        "collectors": {
-                            "type": "array",
-                            "items": {
-                                "type": "string"
-                            }
-                        },
                         "image": {
                             "type": "object",
                             "properties": {
@@ -863,18 +857,18 @@
                         "enabled": {
                             "type": "boolean"
                         },
-                        "image": {
+                        "env": {
                             "type": "object",
                             "properties": {
-                                "repository": {
+                                "GOGC": {
                                     "type": "string"
                                 }
                             }
                         },
-                        "labels": {
+                        "image": {
                             "type": "object",
                             "properties": {
-                                "giantswarm.io/monitoring_basic_sli": {
+                                "repository": {
                                     "type": "string"
                                 }
                             }

diff --git a/helm/kube-prometheus-stack/values.yaml b/helm/kube-prometheus-stack/values.yaml
@@ -346,8 +346,6 @@ kube-prometheus-stack:
       cluster-autoscaler.kubernetes.io/safe-to-evict: "true"
     image:
       repository: giantswarm/prometheus-operator
-    labels:
-      giantswarm.io/monitoring_basic_sli: "true"
     prometheusConfigReloader:
       image:
         repository: giantswarm/prometheus-config-reloader