Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix alloy-logs dashboard #661

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix alloy-logs dashboard #661

wants to merge 4 commits into from

Conversation

hervenicol
Copy link
Contributor

This PR fixes the Alloy / Logs Overview dashboard:

  • templates:

    • cluster_id instead of cluster
    • scrape_job instead of job
  • queries:

    • use proper label names
    • remove unexpected comma
  • screenshots before:
    image

  • screenshots after:
    image

Checklist

  • Update changelog in CHANGELOG.md in an end-user friendly language.

@hervenicol hervenicol self-assigned this Jan 21, 2025
@hervenicol hervenicol requested a review from a team as a code owner January 21, 2025 10:57
@QuentinBisson
Copy link
Contributor

Did you fix it using the mixsin script?

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

- Update DNS dashboard to include memory requests.
- fix Alloy / Logs Overview dashboard.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- fix Alloy / Logs Overview dashboard.
### Fixed
- Fix Alloy / Logs Overview dashboard.

@hervenicol
Copy link
Contributor Author

Did you fix it using the mixsin script?

Nope. Will look at the script and try to do it this way then.

@hervenicol
Copy link
Contributor Author

After looking at the upstream mixins and pulling my (few remaining) hair at the dependencies maze that it is, I decided to just do a bit of sed magic.

I can't guarantee that alloy dashboards are all bug-free, but they certainly work better after these changes than before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants