generated from giantswarm/template-operator
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for migration from Chart Operator to Flux Helm Controller in App Platform #502
Open
ljakimczuk
wants to merge
30
commits into
main
Choose a base branch
from
prepare-for-new-app-platform
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljakimczuk
changed the title
Prepare for new app platform
Prepare for migration from Chart Operator to Flux Helm Controller in App Platform
May 23, 2024
ljakimczuk
force-pushed
the
prepare-for-new-app-platform
branch
2 times, most recently
from
May 24, 2024 13:30
89a4f54
to
e07bbd8
Compare
ljakimczuk
force-pushed
the
prepare-for-new-app-platform
branch
from
June 4, 2024 11:16
1861174
to
661a72c
Compare
This was referenced Jun 5, 2024
ljakimczuk
force-pushed
the
prepare-for-new-app-platform
branch
from
June 18, 2024 10:15
7e15606
to
760744a
Compare
ljakimczuk
force-pushed
the
prepare-for-new-app-platform
branch
from
June 20, 2024 13:32
d684ec1
to
a6ba136
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: giantswarm/roadmap#2455
Description
From now on, the Cluster Apps Operator checks the
app-operator.giantswarm.io/flux-backend
is set on Cluster CR, and if so, it stops creating Chart Operator App CR and makes sure the App Operator is configured to use Helm Controller as a downstream controller.Internally a new OperatorKit resource has been introduced, called
migration
, that is charge of decomissioning the Chart Operator for clusters that have proviously had it. A note for those who may wonder about the necessity of a new resource. The easiest way to remove Chart Operator is to initiate deletion of its App CR and to let the App Operator do the rest. This could be done in theapp
OperatorKit resource of the CAsO, in which Chart Operator is normally handled. However in order to remove the Chart Operator, the App Operator must be configured the old way, but won't be at the time theapp
resource is processed. This is because theconfigmap
resources gets executed before that, which is in charge of re-configuring App Operator.Checklist