Update Sync Period (#257)

* Update Sync Period

* add comment

* add changelog

* add upstream issues

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- Reduce sync-period to 2 minutes to improve scale-up taint removal.
+
 ## [2.20.0] - 2024-07-16
 
 ### Changed

config/helm/deployment-args.yaml

@@ -14,4 +14,6 @@ spec:
             - --metrics-bind-addr=0.0.0.0:8080
             - --feature-gates=EKS=true,EKSEnableIAM=true,EKSAllowAddRoles=false,EKSFargate=false,MachinePool=true,EventBridgeInstanceState=false,AutoControllerIdentityCreator=true,ExternalResourceGC=true,BootstrapFormatIgnition=true
             - --watch-filter=capi
+            # We need to set the sync-period to 2m to improve scale-up time, currently there is no watch in the capa controller that update the provideridlist. Upstream issues https://github.com/kubernetes-sigs/cluster-api/issues/9858 and https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/4618
+            - --sync-period=2m
             - --v=0

helm/cluster-api-provider-aws/templates/apps_v1_deployment_capa-controller-manager.yaml

@@ -55,6 +55,7 @@ spec:
         - --metrics-bind-addr=0.0.0.0:8080
         - --feature-gates=EKS=true,EKSEnableIAM=true,EKSAllowAddRoles=false,EKSFargate=false,MachinePool=true,EventBridgeInstanceState=false,AutoControllerIdentityCreator=true,ExternalResourceGC=true,BootstrapFormatIgnition=true
         - --watch-filter=capi
+        - --sync-period=2m
         - --v=0
         env:
         - name: AWS_SHARED_CREDENTIALS_FILE