Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kubevip #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add kubevip #1

wants to merge 1 commit into from

Conversation

anvddriesch
Copy link
Contributor

This PR:

  • adds/changes/removes etc

Testing

Description on how cloud-provider-proxmox can be tested.

  • fresh install works
    • AWS
    • Azure
    • KVM
  • upgrade from previous version works
    • AWS
    • Azure
    • KVM

Other testing

Description of features to additionally test for cloud-provider-proxmox installations.

  • check reconciliation of existing resources after upgrading
  • X still works after upgrade
  • Y is installed correctly

Checklist

  • Update changelog in CHANGELOG.md.
  • Make sure values.yaml and values.schema.json are valid.

@anvddriesch anvddriesch self-assigned this Jan 8, 2025
@anvddriesch anvddriesch requested a review from a team January 8, 2025 07:47
@vxav
Copy link

vxav commented Jan 8, 2025

Sorry to be a pain here but I thought it might be better to start individual charts for kube-vip and kube-vip-cloud-provider.

Managing cloud-provider-vsphere has proven horrible.
And that way we can manage/update kube-vip and kube-vip cloud provider from one place (their own charts) to be consumed by multiple providers (vsphere, nutanix, proxmox, metal3?).

As for this app (cloud-provider-proxmox-app) I found this CCM (CPI) for proxmox but I'm not sure how official this is. That one looks more official but the last commit is 8 months old. Maybe @glitchcrab will have a clue as he knows proxmox, or maybe @AverageMarcus who runs it at home iirc.

@anvddriesch
Copy link
Contributor Author

I would actually prefer that as well. 😄

@AverageMarcus
Copy link
Member

I think @glitchcrab would know better than me. I don't run bare Kubernetes directly on Proxmox. Instead I use Talos (and no cluster-api).

@glitchcrab
Copy link
Member

I've already talked to Antonia about this during standup, but I'll add it here for preservation reasons - the repos by sergelogvinov are generally accepted as the defacto standard at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants