Skip to content

Troubleshooting: expand and update #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 29, 2024
Merged

Conversation

grahamperrin
Copy link
Contributor

@grahamperrin grahamperrin commented Dec 29, 2024

Add a section for Secure Boot.

Link to STABLE.

For hardware components, direct readers to hardware information that is provided by the FreeBSD Primary Release Engineering Team.

Add two dual-GPU scenarios.

Add a placeholder (ellipsis) subheading for the section that is incomplete.

Whilst here, reword things a little.

Original (draft) Summary by Sourcery

Expand and update the troubleshooting guide by adding Secure Boot information, updating links, and rewording sections for clarity.

Documentation:

  • Add information about disabling Secure Boot in BIOS settings for troubleshooting boot issues.
  • Update the link to the FreeBSD STABLE branch for hardware support information.
  • Include a placeholder for missing desktop environment issues in the troubleshooting guide.
  • Reword and clarify sections on hardware support and installation media corruption.

Mention Secure Boot. Link to STABLE.

Add a placeholder (ellipsis) for the desktop environment not appearing.

Whilst here, reword things a little.
Copy link
Contributor

sourcery-ai bot commented Dec 29, 2024

Reviewer's Guide by Sourcery

This pull request expands and updates the troubleshooting documentation, focusing on Secure Boot, hardware compatibility, and dual-GPU scenarios.

State diagram for boot troubleshooting process

stateDiagram-v2
    [*] --> CheckSecureBoot
    CheckSecureBoot --> DisableSecureBoot: Secure Boot enabled
    DisableSecureBoot --> AttemptBoot
    CheckSecureBoot --> AttemptBoot: Secure Boot disabled
    AttemptBoot --> Success: System boots
    AttemptBoot --> HardwareCheck: Boot fails
    HardwareCheck --> TryDifferentComputer: Hardware suspected
    TryDifferentComputer --> MediaCheck: Fails on different computer
    TryDifferentComputer --> HardwareIssue: Works on different computer
    HardwareCheck --> MediaCheck: Media suspected
    MediaCheck --> DownloadNewISO
    DownloadNewISO --> CreateNewUSB
    CreateNewUSB --> AttemptBoot
Loading

File-Level Changes

Change Details Files
Added a section to guide users on disabling Secure Boot if enabled in BIOS settings.
  • Added information about Secure Boot and its impact on FreeBSD.
source/user/installation-guide/troubleshooting.md
Updated hardware compatibility information to direct users to FreeBSD's official resources.
  • Replaced a general hardware compatibility link with a dynamic link based on the GhostBSD version.
  • Added instructions on how to determine the FreeBSD version used by GhostBSD.
source/user/installation-guide/troubleshooting.md
Included two common dual-GPU scenarios that may prevent reaching the graphical desktop environment.
  • Added information about potential issues with NVIDIA Optimus and dual-GPU Macs.
  • Suggested disabling one of the GPUs in BIOS settings if possible.
source/user/installation-guide/troubleshooting.md
Added a placeholder for an incomplete section and updated the outdated ISO image link.
  • Replaced the outdated ISO image link with the latest image link.
  • Added a placeholder subheading for the incomplete section.
source/user/installation-guide/troubleshooting.md
Improved clarity and wording throughout the troubleshooting guide.
  • Reworded sections for better clarity and conciseness.
source/user/installation-guide/troubleshooting.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@grahamperrin
Copy link
Contributor Author

https://docs.freebsd.org/en/books/faq/#hardware in the rewritten book of FAQ is not a good point of reference.

Re: https://codeberg.org/grahamperrin/freebsd-doc/pulls/21 the first FAQ link for graphics is to https://wiki.freebsd.org/Graphics/Intel-GPU-Matrix, which is explicitly stale with an obsolete table; and so on.

For hardware components, the FreeBSD FAQ book currently lacks what's
required.

So, encourage people to read the much more informative hardware
information that is provided by the FreeBSD Primary Release Engineering
Team.
The first of the two symptoms is based on
https://old.reddit.com/r/GhostBSD/comments/1h3cpjm/problem_for_install_ghostbsd/m3ljzbu/?context=2

The second is based on ghostbsd/issues#14

Revert to 'section' (not 'page') to describe what is incomplete.
Shorten the subheading.

Be a little more descriptive about auto-config.
@grahamperrin grahamperrin marked this pull request as ready for review December 29, 2024 14:46
@grahamperrin grahamperrin requested review from a team as code owners December 29, 2024 14:46
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @grahamperrin - I've reviewed your changes - here's some feedback:

Overall Comments:

  • There's a typo in the word 'occasionally' (spelled as 'ocassionally') that appears in the document.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericbsd ericbsd self-requested a review December 29, 2024 16:08
ericbsd
ericbsd previously approved these changes Dec 29, 2024
Copy link
Member

@ericbsd ericbsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericbsd ericbsd merged commit 1877184 into ghostbsd:master Dec 29, 2024
1 check passed
@grahamperrin
Copy link
Contributor Author

Thanks!

Side notes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants