Skip to content

Fix code compatibility issues. #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix code compatibility issues. #63

wants to merge 1 commit into from

Conversation

@kailiangchen
Copy link

@kailiangchen kailiangchen commented Feb 23, 2018

No description provided.

@itdaniher
Copy link

itdaniher commented Feb 23, 2018

Thanks!! I'll take a look and try and get this merged in the next week!

itdaniher
itdaniher approved these changes Feb 23, 2018
View reviewed changes
Copy link

@itdaniher itdaniher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kailiangchen
Copy link
Author

kailiangchen commented Feb 24, 2018

@itdaniher Thx, although not sure what to do with the failed checks?

@itdaniher
Copy link

itdaniher commented Feb 24, 2018

I need to work over the CI, I wouldn't worry about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@itdaniher itdaniher itdaniher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kailiangchen @itdaniher