abootimg: Improve compatability with no-initrd abootimg configs#3
abootimg: Improve compatability with no-initrd abootimg configs#3johnstultz-work wants to merge 1 commit intoggrandou:masterfrom
Conversation
With newer AOSP devices, system can be used as rootfs, resulting in no initrd being used in the bootimg. Without this patch, 'abootimg -x' on such an image would result with: /home/jstultz/noinitrd-boot.img: ramdisk size is null /home/jstultz/noinitrd-boot.img: not a valid Android Boot Image. This patch just avoids failing out when we see a null ramdisk size. Signed-off-by: John Stultz <john.stultz@linaro.org>
|
This patch is required to work with stock OrangePi images. Please merge. |
|
Could someone merge this PR please? It fixes a severe issue when working with current Android images. LGTM - +1 |
|
"someone". I understand your corporate want this, I think you can feel free to fork it and maintain it. Also "current Android images" doesn't need this because of Android Q's first-stage init. If I'm not mistaken, this is required exclusively on Android Pie devices running system-as-root without A/B slots. |
Yes.
I see that. It doesn't mean they won't take a few minutes out of their time to press "merge".
This doesn't have anything to do with "my corporate".
Okay, good to know. It's still required for certain use-cases though. |
With newer AOSP devices, system can be used as rootfs, resulting
in no initrd being used in the bootimg.
Without this patch, 'abootimg -x' on such an image would result
with:
/home/jstultz/noinitrd-boot.img: ramdisk size is null
/home/jstultz/noinitrd-boot.img: not a valid Android Boot Image.
This patch just avoids failing out when we see a null ramdisk size.
Signed-off-by: John Stultz john.stultz@linaro.org