refactor: split chat.cpp to reduce compile time #17416
Open
+2,891
−2,836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
reviewed
Nov 24, 2025
Comment on lines
+9
to
+10
| #include <minja/chat-template.hpp> | ||
| #include <minja/minja.hpp> |
Collaborator
There was a problem hiding this comment.
I don't think this solution resolve the main concern here:
This won't reduce the total compile time, but will provide a better DX, as most of the time whenever there is a new model that need to be supported, contributors need to modify code in common_chat_parse_*
As long as we still include these headers, compilation time will still be long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17329
Split
common/chat.cppinto two files to improve compile times for contributors working on chat template support.