Skip to content

vulkan: throw system error instead of SIGABRT during init on older devices #16156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

vulkan: throw system error instead of SIGABRT during init on older devices #16156

wants to merge 2 commits into from
+7 −1

Conversation

DmyMi
Copy link

@DmyMi DmyMi commented Sep 21, 2025

Fixes #16142

Main issue is llama_supports_gpu_offload should not get SIGABRT if backend can't initialize correctly in ggml_vk_instance_init. System error will make sure it is not added to registry anyway.

Optionally, added catches in ggml_backend_vk_reg to return null for any errors, unless this was intended to be handled upstream. In that case i can remove that commit.

@DmyMi DmyMi requested a review from 0cc4m as a code owner September 21, 2025 18:41
@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0cc4m 0cc4m Awaiting requested review from 0cc4m 0cc4m is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misc. bug: llama_supports_gpu_offload SIGABRT for older Vulkan versions
1 participant
@DmyMi