rpc : use GGML_LOG_* for logging #16129
Open
+66
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
ggml
ggerganov
reviewed
Sep 20, 2025
Add --verbose to rpc-server and configure the ggml logger to print debug messages only if set. Add helper macro LOG_DBG() which does an early check of the verbose flag before calling GGML_LOG_DEBUG(). Make sure we log a debug message for every server function.
rgerganov
force-pushed
the
rpc-fixlog
branch
from
cc8fee7 to
eda3897
Compare
ggerganov
reviewed
Sep 22, 2025
Comment on lines
23
to
25
| GGML_BACKEND_API void ggml_backend_rpc_start_server(ggml_backend_t backend, const char * endpoint, | ||
| const char * cache_dir, | ||
| const char * cache_dir, bool verbose, | ||
| size_t free_mem, size_t total_mem); |
There was a problem hiding this comment.
I think it's better to keep this function as it is and read the verbosity level from an environment variable, for example GGML_RPC_DEBUG. The idea is to keep the API clean from verbosity/log related settings.
This way, in order to see the internal ggml-rpc debug logs, you can run:
GGML_RPC_DEBUG=1 rpc-server ... --verbose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use GGML_LOG_DEBUG() for debug messages and configure the logger to print them only when rpc-server is started with --verbose. Make sure we log a debug message for every server function.