Skip to content

ggml : add ggml_op_is_empty #16122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2025
Merged

ggml : add ggml_op_is_empty #16122

merged 2 commits into from
Sep 22, 2025
+16 −17

Conversation

ggerganov
Copy link
Member

It is commonly needed, especially in graph_compute backend implementations, to filter ops that are "empty", such as view, reshapes, etc. This patch declares a common function in ggml.h to be reused.

@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning Apple Metal https://en.wikipedia.org/wiki/Metal_(API) labels Sep 20, 2025
slaren
slaren approved these changes Sep 20, 2025
View reviewed changes
Copy link
Member

@slaren slaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if the definition was in a header so that it can be inlined.

@ggerganov
Copy link
Member Author

Moved to ggml-impl.h - there won't be a public API for now.

@ggerganov ggerganov merged commit a71ae3b into master Sep 22, 2025
54 of 55 checks passed
@ggerganov ggerganov deleted the gg/ggml-op-is-empty branch September 22, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaren slaren slaren approved these changes

@jeffbolznv jeffbolznv jeffbolznv approved these changes

Assignees
No one assigned
Labels
Apple Metal https://en.wikipedia.org/wiki/Metal_(API) ggml changes relating to the ggml tensor library for machine learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggerganov @slaren @jeffbolznv