make "server-core" library #14331
Closed
make "server-core" library #14331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arnej27959 Good day! I think that serve is not a suitable name, since it intersects with the server entity. Maybe call it server-core? or serve-core? (other options are welcome) |
arnej27959
force-pushed
the
arnej/make-serve-library
branch
from
8abb76a to
db0a6ed
Compare
|
I like your suggestion "server-core"; I've updated the branch to get the newer changes and reflect the new name. |
arnej27959
force-pushed
the
arnej/make-serve-library
branch
from
db0a6ed to
c9c27c2
Compare
|
superseded by #16147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using llama.cpp from java using the wrapper from https://github.com/kherud/java-llama.cpp at the moment.
This wrapper uses code from the "tools/server" directory, and it would be most helpful to split that code into a library part (a generic server) and the HTTP-specific part. This PR creates a new library in "tools/serve" which can be used directly, while keeping the main() routine etc in "server". This should not impact current functionality in any way, it's just moving some of the code. This could also be useful if someone wants to build a server using RPC/protobuf instead of HTTP/json, for example.
I hope this contribution might be welcome.