Skip to content

HIP: rocWMMA documentation and enabling in workflow builds #12179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 6, 2025
Merged

HIP: rocWMMA documentation and enabling in workflow builds #12179

merged 3 commits into from
Mar 6, 2025

Conversation

hjc4869
Copy link
Contributor

@hjc4869 hjc4869 commented Mar 4, 2025 •
edited
Loading

  1. Enable rocWMMA for Windows and Ubuntu in official GitHub Actions.
  2. Add documentation of GGML_HIP_ROCWMMA_FATTN CMake option.

build.yml changes validated in forked branches

Related: #12032

@github-actions github-actions bot added documentation Improvements or additions to documentation devops improvements to build systems and github actions labels Mar 4, 2025
@hjc4869 hjc4869 mentioned this pull request Mar 4, 2025
Merged
@JohannesGaessler JohannesGaessler merged commit 3ffbbd5 into ggml-org:master Mar 6, 2025
43 checks passed
@JohannesGaessler
Copy link
Collaborator

Sorry, I merged this PR but it seems the CI on master is now failing because of it due to the rocWMMA files not being found. The CI was successful for the PR though; are there different setups?

@hjc4869
Copy link
Contributor Author

hjc4869 commented Mar 6, 2025

Let me take a look what's possibly going wrong.

@hjc4869 hjc4869 deleted the ci-rocwmma branch March 6, 2025 14:13
@hjc4869 hjc4869 restored the ci-rocwmma branch March 6, 2025 14:14
@hjc4869
Copy link
Contributor Author

hjc4869 commented Mar 6, 2025

windows-latest-cmake-hip job didn't specify AMDGPU_TARGETS, thus it was using gfx906 as default target, and it didn't support WMMA so it skipped compiling related device code.

windows-latest-cmake-hip-release has AMDGPU_TARGETS specified, but the job was skipped in non-master branches, so neither my private build nor PR check has actually validated the WMMA build under Windows.

The issue is likely due to not using absolute paths in -DCMAKE_CXX_FLAGS. There will also be some problems by using $PWD (contains \ backslash on Windows) with Unix Makefiles under Windows. I'm validating a fix on my fork branch and will send a fix after it's ready.

@hjc4869
Copy link
Contributor Author

hjc4869 commented Mar 6, 2025

PR sent: #12230

@hjc4869 hjc4869 deleted the ci-rocwmma branch March 6, 2025 18:53
@hjc4869 hjc4869 mentioned this pull request Mar 7, 2025
Merged
mglambda pushed a commit to mglambda/llama.cpp that referenced this pull request Mar 8, 2025
@hjc4869 @mglambda
HIP: rocWMMA documentation and enabling in workflow builds (ggml-org#…
72d89f3 
…12179)

* Enable rocWMMA for Windows CI build

* Enable for Ubuntu

* GGML_HIP_ROCWMMA_FATTN documentation work
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Mar 19, 2025
@hjc4869 @arthw
HIP: rocWMMA documentation and enabling in workflow builds (ggml-org#…
de6fff6 
…12179)

* Enable rocWMMA for Windows CI build

* Enable for Ubuntu

* GGML_HIP_ROCWMMA_FATTN documentation work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaren slaren slaren approved these changes

@JohannesGaessler JohannesGaessler JohannesGaessler approved these changes

Assignees
No one assigned
Labels
devops improvements to build systems and github actions documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjc4869 @JohannesGaessler @slaren