Make HasDisplayHandle optional in WindowHandle
#8782
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Followup to #8012 (comment) and rust-windowing/softbuffer#298 (comment) (CC @cwfitzgerald @dhardy)
Description
While true for some window objects like
winit'sWindowobject, not everyone is or should be required to return their display handle in the same place as the window handle, by means of implementing bothRawDisplayHandleandRawWindowHandleon the same object.Additionally some APIs, specifically most/all GL(ES) context creation APIs require the
RawDisplayHandleup-front to create a context that is compatible with that "compositor connection".For this reason callers should no longer be required to pass a single object that implements both
HasDisplayHandleandHasWindowHandle, allowing the former to becomeOptional in favour of taking the one stored (and kept alive!) in theInstance.HasDisplayHandlecan still be passed in this position however, because APIs like Vulkan have completely pushed out compositor integration via surfaces to the edge of the API and can technically let one instance or device render into multiple differentRawDisplayHandle"compositor connections" concurrently.Testing
Squash or Rebase?
Doesn't matter.
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.