Add clip distances validation for maxInterStageShaderVariables
#8762
+181
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
max_inter_stage_shader_variables-clip_distances
branch
3 times, most recently
from
2004d9a to
f70488b
Compare
6 tasks
ErichDonGubler
force-pushed
the
max_inter_stage_shader_variables-clip_distances
branch
2 times, most recently
from
9a8ea87 to
152fedd
Compare
ErichDonGubler
force-pushed
the
max_inter_stage_shader_variables-clip_distances
branch
7 times, most recently
from
6454d73 to
4a816bf
Compare
andyleiserson
approved these changes
Dec 23, 2025
| ViewIndex, | ||
| BaseInstance, | ||
| BaseVertex, | ||
| ClipDistance { array_size: u32 }, |
Contributor
There was a problem hiding this comment.
Thoughts on putting array_size: Option<u32> in the naga type rather then duplicating the whole thing?
| debug_assert_eq!(stride, 4); | ||
|
|
||
| let naga::ArraySize::Constant(array_size) = size else { | ||
| // TODO: Should we accept override expressions? |
Contributor
There was a problem hiding this comment.
Does naga allow it? I don't think it should be legal based on:
The only valid use of a fixed-size array with an element count that is an override-expression that is not a const-expression is as a memory view in the workgroup address space.
ErichDonGubler
force-pushed
the
max_inter_stage_shader_variables-clip_distances
branch
from
4a816bf to
ca04a30
Compare
Shortly, we're going to add our own functionality to it.
…hader_variables` limit check
ErichDonGubler
force-pushed
the
max_inter_stage_shader_variables-clip_distances
branch
from
ca04a30 to
6a58c70
Compare
ErichDonGubler
commented
Dec 23, 2025
| /// When a pipeline's [`crate::pipeline::RenderPipelineDescriptor::primitive`] is set to | ||
| /// [`wgt::PrimitiveTopology::PointList`]. | ||
| PointListPrimitiveTopology, | ||
| ClipDistance { |
Member
Author
There was a problem hiding this comment.
todo: We should add docs. here, like has been added with the other variants since this draft was started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
maxInterStageShaderComponentstomaxInterStageShaderVariables(minus coverage ofclip-distances) #8652.Testing
New CTS tests have been enabled that cover this functionality, which were previously failing.
Squash or Rebase?
Rebase.