Skip to content

naga: Enforce @must_use for built-in functions #8713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andyleiserson wants to merge 3 commits into
base: trunk
Choose a base branch
from
+815 −679
Open

naga: Enforce @must_use for built-in functions #8713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a6491d
refactor(naga): Extract `call_builtin` to a separate function
andyleiserson Dec 11, 2025
4daa9c7
refactor(naga): Eliminate early returns in `call_builtin`
andyleiserson Dec 11, 2025
8b61d3c
naga: Enforce `@must_use` for built-in functions
andyleiserson Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@ Bottom level categories:

## Unreleased

### Changes

#### naga

- Naga now enforces the `@must_use` attribute on WGSL built-in functions, when applicable. You can waive the error with a phony assignment, e.g., `_ = subgroupElect()`. By @andyleiserson in [#8713](https://github.com/gfx-rs/wgpu/pull/8713).

## v28.0.0 (2025-12-17)

### Major Changes
Expand Down
20 changes: 19 additions & 1 deletion cts_runner/test.lst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,25 @@ webgpu:shader,validation,expression,binary,short_circuiting_and_or:array_overrid
webgpu:shader,validation,expression,binary,short_circuiting_and_or:invalid_types:*
webgpu:shader,validation,expression,binary,short_circuiting_and_or:scalar_vector:op="%26%26";lhs="bool";rhs="bool"
webgpu:shader,validation,expression,call,builtin,all:arguments:test="ptr_deref"
webgpu:shader,validation,expression,call,builtin,max:values:*
webgpu:shader,validation,expression,call,builtin,arrayLength:*
webgpu:shader,validation,expression,call,builtin,barriers:*
webgpu:shader,validation,expression,call,builtin,cos:*
webgpu:shader,validation,expression,call,builtin,floor:*
webgpu:shader,validation,expression,call,builtin,fract:*
webgpu:shader,validation,expression,call,builtin,max:*
webgpu:shader,validation,expression,call,builtin,min:*
webgpu:shader,validation,expression,call,builtin,radians:*
webgpu:shader,validation,expression,call,builtin,sign:*
webgpu:shader,validation,expression,call,builtin,sin:*
webgpu:shader,validation,expression,call,builtin,step:*
webgpu:shader,validation,expression,call,builtin,tan:*
webgpu:shader,validation,expression,call,builtin,tanh:*
webgpu:shader,validation,expression,call,builtin,textureNumLayers:*
webgpu:shader,validation,expression,call,builtin,textureNumLevels:*
webgpu:shader,validation,expression,call,builtin,textureNumSamples:*
webgpu:shader,validation,expression,call,builtin,textureStore:*
webgpu:shader,validation,expression,call,builtin,trunc:*
webgpu:shader,validation,expression,call,builtin,workgroupUniformLoad:*
webgpu:shader,validation,statement,statement_behavior:invalid_statements:body="break"
webgpu:shader,validation,statement,statement_behavior:invalid_statements:body="break_if"
webgpu:shader,validation,statement,statement_behavior:invalid_statements:body="continue"
Expand Down
Loading