Skip to content

Conversation

@atlv24
Copy link
Collaborator

@atlv24 atlv24 commented Oct 21, 2025

Connections
bevyengine/bevy#21512

Description
Fixes

wgpu_hal::vulkan::instance: VALIDATION [VUID-StandaloneSpirv-MemorySemantics-10871 (0x72170603)]
	vkCreateShaderModule(): pCreateInfo->pCode (spirv-val produced an error):
AtomicIAdd: Memory Semantics with at least one Vulkan-supported storage class semantics bit set (UniformMemory, WorkgroupMemory, ImageMemory, or OutputMemory) must use a non-relaxed memory order (Acquire, Release, or AcquireRelease)

Testing
patched into bevy and fixes linked issue
existing unit tests cover this issue, and validation now passes on my local. i believe ci runner validation layer may be outdated, cus it fails on main for me.

Squash or Rebase?

Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@cwfitzgerald
Copy link
Member

I think this is solving the problem in the wrong direction - we want to have all of the atomics be relaxed, so it seems like we might need to remove the space qualification?

@cwfitzgerald cwfitzgerald self-assigned this Oct 22, 2025
@atlv24 atlv24 changed the title fix(vulkan): add atomic memory semantics fix(vulkan): remove atomic memory semantics Oct 22, 2025
@atlv24
Copy link
Collaborator Author

atlv24 commented Oct 22, 2025

I've removed the memory semantics @cwfitzgerald

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants