Skip to content

Conversation

@Vecvec
Copy link
Contributor

@Vecvec Vecvec commented Oct 21, 2025

Connections
Vulkan side of #6761

Description
With every ray query, creates an extra variable that gets passed around with it that tracks the functions that have been called on it in spirv. HLSL still has UB so I haven't updated the spec. This doesn't track them through function calls, as right now passing ray queries as function arguments is not allowed (might be a metal requirement?).

I have also added emitting debug printf as an option if initialization fails as it could fairly difficult to debug.

Testing
Adds a test that calls the ray queries with invalid values (including NaN and Infinity)

Squash or Rebase? Squash, each of the commits don't really make sense on their own.

Checklist

  • Run cargo fmt.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@Vecvec Vecvec force-pushed the spir-v-safe-ray-query-calls branch from c1c88c1 to 16a5189 Compare October 21, 2025 05:28
@cwfitzgerald cwfitzgerald self-assigned this Oct 22, 2025
@Vecvec Vecvec force-pushed the spir-v-safe-ray-query-calls branch from 014fb78 to 6d674a6 Compare October 24, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants