- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.1k
 
          [d3d12 wgl] Upgrade to windows 0.62 crates
          #8013
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| /// Sum of the memory reserved by all memory blocks including unallocated regions, in bytes. | ||
| // XXX: Rename to total_capacity_bytes following the rename at https://github.com/Traverse-Research/gpu-allocator/pull/266? | ||
| pub total_reserved_bytes: u64, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC @nical based on Traverse-Research/gpu-allocator#226 which got changed in Traverse-Research/gpu-allocator#266.
windows 0.61 crateswindows 0.61-0.62 crates
      windows 0.61-0.62 crateswindows 0.61 crates
      f4122da    to
    44e09d8      
    Compare
  
    | 
           I would have used a version range to include the latest https://github.com/microsoft/windows-rs/releases/tag/69 release since   | 
    
44e09d8    to
    2ccd8ad      
    Compare
  
    2ccd8ad    to
    f84d6da      
    Compare
  
    windows 0.61 crateswindows 0.62 crates
      4273c92    to
    d1d17cf      
    Compare
  
    https://github.com/microsoft/windows-rs/releases/tag/0.61.0 The latest `windows 0.59` and `windows-core 0.59` crates were just released (strangely tagged `0.61`), including some minor code improvements for us. The MSRV has been bumped to `1.74`, but `wgpu` is already on `1.76` anyway.
d1d17cf    to
    b546ade      
    Compare
  
    | 
           Pushing back into #6876  | 
    
Connections
Depends on #6876
Description
Uses the latest
windows 0.62andwindows-core 0.62releases.https://github.com/microsoft/windows-rs/releases/tag/0.61.0
https://github.com/microsoft/windows-rs/releases/tag/63
https://github.com/microsoft/windows-rs/releases/tag/69
Testing
Squash or Rebase?
squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.