Merge branch 'master' into ep-final-ethereum-module

gfukushima · Apr 21, 2024 · 554f2ad · 554f2ad
2 parents e12ab36 + cfc8412
commit 554f2ad
Show file tree

Hide file tree

Showing 23 changed files with 954 additions and 1,407 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -148,7 +148,7 @@ commands:
           name: "Publish Docker Images"
           command: |
             docker login --username "${DOCKER_USER_RW}" --password "${DOCKER_PASSWORD_RW}"
-            ./gradlew --no-daemon --parallel "-Pbranch=${CIRCLE_BRANCH} -PincludeCommitHashInDockerTag=<< pipeline.parameters.include_commit_hash_in_docker_tag >>" uploadDocker
+            ./gradlew --no-daemon --parallel -Pbranch=${CIRCLE_BRANCH} -PincludeCommitHashInDockerTag=<< pipeline.parameters.include_commit_hash_in_docker_tag >> uploadDocker
 
   notify:
     description: "Notify Slack"

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,5 +18,6 @@ the [releases page](https://github.com/Consensys/teku/releases).
 - Added hidden option `--Xdeposit-contract-logs-syncing-enabled` to allow disabling the syncing of the deposit contract logs from the EL. This is useful when running a non-validating node. It is advisable to be used alongside with `--Xeth1-missing-deposits-event-logging-enabled=false` to avoid unnecessary logging of missing deposits.
 - Updated the bootnodes for Chiado and Gnosis networks.
 - Added hidden option `--Xp2p-dumps-to-file-enabled` to enable saving p2p dumps to file.
+- Appends consensus layer (CL) and execution layer (EL) clients' information to the validator graffiti. Check [documentation](https://docs.teku.consensys.io/development/reference/cli#validators-graffiti-client-append-format) for available configuration options.
 
 ### Bug Fixes
diff --git a/.../src/main/java/tech/pegasys/teku/validator/coordinator/BlockOperationSelectorFactory.java b/.../src/main/java/tech/pegasys/teku/validator/coordinator/BlockOperationSelectorFactory.java
diff --git a/...dator/src/test/java/tech/pegasys/teku/validator/coordinator/AbstractBlockFactoryTest.java b/...dator/src/test/java/tech/pegasys/teku/validator/coordinator/AbstractBlockFactoryTest.java
@@ -33,6 +33,7 @@
 import org.apache.tuweni.units.bigints.UInt256;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
+import tech.pegasys.teku.bls.BLSPublicKey;
 import tech.pegasys.teku.bls.BLSSignature;
 import tech.pegasys.teku.bls.BLSSignatureVerifier;
 import tech.pegasys.teku.ethereum.performance.trackers.BlockProductionPerformance;
@@ -53,12 +54,15 @@
 import tech.pegasys.teku.spec.datastructures.blocks.blockbody.versions.altair.SyncAggregate;
 import tech.pegasys.teku.spec.datastructures.blocks.blockbody.versions.bellatrix.BeaconBlockBodyBellatrix;
 import tech.pegasys.teku.spec.datastructures.blocks.blockbody.versions.bellatrix.BlindedBeaconBlockBodyBellatrix;
+import tech.pegasys.teku.spec.datastructures.builder.BuilderBid;
 import tech.pegasys.teku.spec.datastructures.builder.BuilderPayload;
 import tech.pegasys.teku.spec.datastructures.execution.BlobsBundle;
+import tech.pegasys.teku.spec.datastructures.execution.BuilderBidOrFallbackData;
+import tech.pegasys.teku.spec.datastructures.execution.BuilderPayloadOrFallbackData;
 import tech.pegasys.teku.spec.datastructures.execution.ExecutionPayload;
 import tech.pegasys.teku.spec.datastructures.execution.ExecutionPayloadHeader;
 import tech.pegasys.teku.spec.datastructures.execution.ExecutionPayloadResult;
-import tech.pegasys.teku.spec.datastructures.execution.HeaderWithFallbackData;
+import tech.pegasys.teku.spec.datastructures.execution.GetPayloadResponse;
 import tech.pegasys.teku.spec.datastructures.metadata.BlockContainerAndMetaData;
 import tech.pegasys.teku.spec.datastructures.operations.Attestation;
 import tech.pegasys.teku.spec.datastructures.operations.AttesterSlashing;
@@ -197,8 +201,6 @@ protected BlockContainerAndMetaData assertBlockCreated(
             SafeFuture.completedFuture(
                 Optional.of(dataStructureUtil.randomPayloadExecutionContext(false))));
 
-    setupExecutionLayerBlockAndBlobsProduction();
-
     final BLSSignature randaoReveal = dataStructureUtil.randomSignature();
     final Bytes32 bestBlockRoot = recentChainData.getBestBlockRoot().orElseThrow();
     final BeaconState blockSlotState =
@@ -209,24 +211,25 @@ protected BlockContainerAndMetaData assertBlockCreated(
 
     when(syncCommitteeContributionPool.createSyncAggregateForBlock(newSlot, bestBlockRoot))
         .thenAnswer(invocation -> createEmptySyncAggregate(spec));
-    executionPayloadBuilder.accept(blockSlotState);
 
     final UInt256 blockExecutionValue;
     final UInt64 blockProposerRewards;
 
     if (milestone.isGreaterThanOrEqualTo(SpecMilestone.BELLATRIX)) {
       blockExecutionValue = dataStructureUtil.randomUInt256();
       blockProposerRewards = dataStructureUtil.randomUInt64();
-
-      // inject values into slot caches
+      // increase block proposer rewards to test the consensus block value
       final SlotCaches slotCaches = BeaconStateCache.getSlotCaches(blockSlotState);
-      slotCaches.setBlockExecutionValue(blockExecutionValue);
       slotCaches.increaseBlockProposerRewards(blockProposerRewards);
     } else {
       blockExecutionValue = UInt256.ZERO;
       blockProposerRewards = UInt64.ZERO;
     }
 
+    setupExecutionLayerBlockAndBlobsProduction(spec, blockExecutionValue);
+
+    executionPayloadBuilder.accept(blockSlotState);
+
     final BlockContainerAndMetaData blockContainerAndMetaData =
         safeJoin(
             blockFactory.createUnsignedBlock(
@@ -291,7 +294,8 @@ protected SignedBeaconBlock assertBlockUnblinded(
 
     // no need to prepare blobs bundle when only testing block unblinding
     when(executionLayer.getUnblindedPayload(blindedBlock, BlockPublishingPerformance.NOOP))
-        .thenReturn(SafeFuture.completedFuture(executionPayload));
+        .thenReturn(
+            SafeFuture.completedFuture(BuilderPayloadOrFallbackData.create(executionPayload)));
 
     final SignedBeaconBlock unblindedBlock =
         blockFactory
@@ -365,7 +369,7 @@ protected BlockAndBlobSidecars createBlockAndBlobSidecars(
 
     // simulate caching of the builder payload
     when(executionLayer.getCachedUnblindedPayload(signedBlockContainer.getSlot()))
-        .thenReturn(builderPayload);
+        .thenReturn(builderPayload.map(BuilderPayloadOrFallbackData::create));
 
     final List<BlobSidecar> blobSidecars =
         blockFactory.createBlobSidecars(signedBlockContainer, BlockPublishingPerformance.NOOP);
@@ -446,63 +450,42 @@ protected BuilderPayload prepareBuilderPayload(final Spec spec, final int blobsC
     return builderPayload;
   }
 
-  private void setupExecutionLayerBlockAndBlobsProduction() {
-    // pre Deneb
+  private void setupExecutionLayerBlockAndBlobsProduction(final Spec spec, final UInt256 value) {
+    // non-blinded
     when(executionLayer.initiateBlockProduction(any(), any(), eq(false), any(), any()))
         .thenAnswer(
             args -> {
               final ExecutionPayloadResult executionPayloadResult =
-                  new ExecutionPayloadResult(
+                  ExecutionPayloadResult.createForLocalFlow(
                       args.getArgument(0),
-                      Optional.of(SafeFuture.completedFuture(executionPayload)),
-                      Optional.empty(),
-                      Optional.empty(),
-                      Optional.empty());
+                      SafeFuture.completedFuture(
+                          blobsBundle
+                              .map(
+                                  bundle ->
+                                      new GetPayloadResponse(
+                                          executionPayload, value, bundle, false))
+                              .orElseGet(() -> new GetPayloadResponse(executionPayload, value))));
               cachedExecutionPayloadResult = executionPayloadResult;
               return executionPayloadResult;
             });
+    // blinded
     when(executionLayer.initiateBlockProduction(any(), any(), eq(true), any(), any()))
         .thenAnswer(
             args -> {
+              final BuilderBid builderBid =
+                  SchemaDefinitionsBellatrix.required(spec.getGenesisSchemaDefinitions())
+                      .getBuilderBidSchema()
+                      .createBuilderBid(
+                          builder -> {
+                            builder.header(executionPayloadHeader);
+                            builderBlobKzgCommitments.ifPresent(builder::blobKzgCommitments);
+                            builder.value(value);
+                            builder.publicKey(BLSPublicKey.empty());
+                          });
               final ExecutionPayloadResult executionPayloadResult =
-                  new ExecutionPayloadResult(
-                      args.getArgument(0),
-                      Optional.empty(),
-                      Optional.empty(),
-                      Optional.of(
-                          SafeFuture.completedFuture(
-                              HeaderWithFallbackData.create(executionPayloadHeader))),
-                      Optional.empty());
-              cachedExecutionPayloadResult = executionPayloadResult;
-              return executionPayloadResult;
-            });
-    // post Deneb
-    when(executionLayer.initiateBlockAndBlobsProduction(any(), any(), eq(false), any(), any()))
-        .thenAnswer(
-            args -> {
-              final ExecutionPayloadResult executionPayloadResult =
-                  new ExecutionPayloadResult(
-                      args.getArgument(0),
-                      Optional.of(SafeFuture.completedFuture(executionPayload)),
-                      Optional.of(SafeFuture.completedFuture(blobsBundle)),
-                      Optional.empty(),
-                      Optional.empty());
-              cachedExecutionPayloadResult = executionPayloadResult;
-              return executionPayloadResult;
-            });
-    when(executionLayer.initiateBlockAndBlobsProduction(any(), any(), eq(true), any(), any()))
-        .thenAnswer(
-            args -> {
-              final ExecutionPayloadResult executionPayloadResult =
-                  new ExecutionPayloadResult(
+                  ExecutionPayloadResult.createForBuilderFlow(
                       args.getArgument(0),
-                      Optional.empty(),
-                      Optional.empty(),
-                      Optional.of(
-                          SafeFuture.completedFuture(
-                              HeaderWithFallbackData.create(
-                                  executionPayloadHeader, builderBlobKzgCommitments))),
-                      Optional.empty());
+                      SafeFuture.completedFuture(BuilderBidOrFallbackData.create(builderBid)));
               cachedExecutionPayloadResult = executionPayloadResult;
               return executionPayloadResult;
             });